Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 510353003: Rollback Print and Cancel button positions change, it breaks the tab order. (Closed)

Created:
6 years, 3 months ago by Aleksey Shlyapnikov
Modified:
6 years, 3 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Rollback Print and Cancel button positions change, it breaks the tab order. BUG=407974 Committed: https://crrev.com/cb51cf2c8f073354465f6d3e759f031970e60f3f Cr-Commit-Position: refs/heads/master@{#292555}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/print_preview/print_header.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Aleksey Shlyapnikov
alekseys@chromium.org changed reviewers: + vitalybuka@chromium.org
6 years, 3 months ago (2014-08-28 21:57:32 UTC) #1
Aleksey Shlyapnikov
6 years, 3 months ago (2014-08-28 21:57:33 UTC) #2
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 3 months ago (2014-08-28 21:58:23 UTC) #3
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 3 months ago (2014-08-28 21:58:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alekseys@chromium.org/510353003/1
6 years, 3 months ago (2014-08-28 21:59:31 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 3 months ago (2014-08-28 23:44:05 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 23:57:59 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/7020)
6 years, 3 months ago (2014-08-28 23:58:00 UTC) #8
Aleksey Shlyapnikov
The CQ bit was checked by alekseys@chromium.org
6 years, 3 months ago (2014-08-29 01:04:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alekseys@chromium.org/510353003/1
6 years, 3 months ago (2014-08-29 01:06:02 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as bbb514c6704acf88edcb6d81239a3c79ab7d0f0d
6 years, 3 months ago (2014-08-29 02:38:52 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:05:38 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/cb51cf2c8f073354465f6d3e759f031970e60f3f
Cr-Commit-Position: refs/heads/master@{#292555}

Powered by Google App Engine
This is Rietveld 408576698