Fix Blink roll script to handle git revisions.

Fix Blink roll script to handle git revisions.

BUG=406867

[mlamouri (slow - plz ping), 2014-08-28 13:40:27]

mlamouri@chromium.org changed reviewers:
+ dpranke@google.com, eseidel@chromium.org

[eseidel, 2014-08-28 14:32:45]

eseidel@chromium.org changed reviewers:
+ borenet@chromium.org

[eseidel, 2014-08-28 14:32:45]

Eric Boren is a better owner for this code these days than I am.

He also has a competing fix:
https://codereview.chromium.org/515893002/

[eseidel, 2014-08-28 14:33:37]

I'm told that depot_tools/roll-dep is actually the "modern" script for this kind
of thing.

and I now realize that you're fixing safely-roll-blink instead of the autoroll
bot.  boren is still a better reviewer than I. :)

[borenet2, 2014-08-28 14:45:56]

On 2014/08/28 14:33:37, eseidel wrote:
> I'm told that depot_tools/roll-dep is actually the "modern" script for this
kind
> of thing.
> 
> and I now realize that you're fixing safely-roll-blink instead of the autoroll
> bot.  boren is still a better reviewer than I. :)

Now that the AutoRoll Bot is using roll-dep, are there any users of this script?
 If not, per comments on https://codereview.chromium.org/503813002/ we should
probably remove it.

[eseidel, 2014-08-28 14:53:51]

We certainly should remove safely-roll-blink, since safely-roll-deps replaced
it.   roll-deps just doesn't have a "automatically post and CQ" option, right?

I'm all for removing everything but the one true path.

I worry that the Blink Roll Bot has not been reliable enough as of late, and
until it's reliable again we need to leave gardeners some easy way to roll.  But
if we believe that usage is covered in other ways, then yes, please nuke from
orbit!

[borenet, 2014-08-28 14:57:22]

On 2014/08/28 14:53:51, eseidel wrote:
> We certainly should remove safely-roll-blink, since safely-roll-deps replaced
> it.   roll-deps just doesn't have a "automatically post and CQ" option, right?
> 
> I'm all for removing everything but the one true path.
> 
> I worry that the Blink Roll Bot has not been reliable enough as of late, and
> until it's reliable again we need to leave gardeners some easy way to roll. 
But
> if we believe that usage is covered in other ways, then yes, please nuke from
> orbit!

Yeah, so the missing pieces in roll-dep are the commit/upload/CQ, which
safely-roll-* handled.  ARB has been updated to do this, but ideally roll-dep
should, at the very least, commit the change to DEPS with an appropriate message
including the googlesource log link.

[mlamouri (slow - plz ping), 2014-08-28 15:01:35]

On 2014/08/28 14:57:22, borenet wrote:
> On 2014/08/28 14:53:51, eseidel wrote:
> > We certainly should remove safely-roll-blink, since safely-roll-deps
replaced
> > it.   roll-deps just doesn't have a "automatically post and CQ" option,
right?
> > 
> > I'm all for removing everything but the one true path.
> > 
> > I worry that the Blink Roll Bot has not been reliable enough as of late, and
> > until it's reliable again we need to leave gardeners some easy way to roll. 
> But
> > if we believe that usage is covered in other ways, then yes, please nuke
from
> > orbit!
> 
> Yeah, so the missing pieces in roll-dep are the commit/upload/CQ, which
> safely-roll-* handled.  ARB has been updated to do this, but ideally roll-dep
> should, at the very least, commit the change to DEPS with an appropriate
message
> including the googlesource log link.

I was confused to see a safely-roll-blink.py and safely-roll-dep.py and wasn't
sure which one was used. Blink Gardening doc points to the -blink.py script so I
assume it was the one to be used. I would gladly fix the other one if that's
what we want.

[szager1, 2014-08-28 18:12:53]

On 2014/08/28 14:57:22, borenet wrote:
> On 2014/08/28 14:53:51, eseidel wrote:
> > We certainly should remove safely-roll-blink, since safely-roll-deps
replaced
> > it.   roll-deps just doesn't have a "automatically post and CQ" option,
right?
> > 
> > I'm all for removing everything but the one true path.
> > 
> > I worry that the Blink Roll Bot has not been reliable enough as of late, and
> > until it's reliable again we need to leave gardeners some easy way to roll. 
> But
> > if we believe that usage is covered in other ways, then yes, please nuke
from
> > orbit!
> 
> Yeah, so the missing pieces in roll-dep are the commit/upload/CQ, which
> safely-roll-* handled.  ARB has been updated to do this, but ideally roll-dep
> should, at the very least, commit the change to DEPS with an appropriate
message
> including the googlesource log link.

roll-dep already creates the commit message, and puts it in .git/MERGE_MSG.  If
you then 'git add DEPS && git commit --no-edit', it will use that message.

[mlamouri (slow - plz ping), 2014-08-29 10:10:59]

I fixed safely-roll-deps.py:
https://codereview.chromium.org/524583002/

And removed safely-roll-blink.py:
https://codereview.chromium.org/523573002/

I guess this CL can be closed now.