Source/core/frame/DOMWindow.cpp - Issue 51033005: Add a use counter and deprecation message for showModalDialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/DOMWindow.cpp

Issue 51033005: Add a use counter and deprecation message for showModalDialog (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: add missing result Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/DOMWindow.cpp

diff --git a/Source/core/frame/DOMWindow.cpp b/Source/core/frame/DOMWindow.cpp

index 0a0e0def9c8ef9c7d674ce05d013f0363fa0ca53..15a499eed8652e0d313279030c78d9f2f4ba5fc9 100644

--- a/Source/core/frame/DOMWindow.cpp

+++ b/Source/core/frame/DOMWindow.cpp

@@ -1838,6 +1838,8 @@ void DOMWindow::showModalDialog(const String& urlString, const String& dialogFea

if (!canShowModalDialogNow(m_frame) || !firstWindow->allowPopUp())

return;

+ UseCounter::countDeprecation(this, UseCounter::ShowModalDialog);

WindowFeatures windowFeatures(dialogFeaturesString, screenAvailableRect(m_frame->view()));

Frame* dialogFrame = createWindow(urlString, emptyAtom, windowFeatures,

activeWindow, firstFrame, m_frame, function, functionContext);