Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Unified Diff: base/memory/ref_counted_unittest.cc

Issue 510323002: Disable scoped_refptr operator T* on Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/memory/ref_counted.h ('K') | « base/memory/ref_counted.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/memory/ref_counted_unittest.cc
diff --git a/base/memory/ref_counted_unittest.cc b/base/memory/ref_counted_unittest.cc
index 7a033f3a2a79d0589887b00e21f9eabdad6d57f5..a54d8bc0b7dde777c2d70fa3215e0d5d0a926e14 100644
--- a/base/memory/ref_counted_unittest.cc
+++ b/base/memory/ref_counted_unittest.cc
@@ -61,6 +61,8 @@ TEST(RefCountedUnitTest, ScopedRefPtrToSelf) {
EXPECT_TRUE(ScopedRefPtrToSelf::was_destroyed());
}
+// Temporarily disabled while the conversion operator is being removed.
+#if 0
jamesr 2014/08/28 18:19:43 just delete the code, it'll live on in git until i
TEST(RefCountedUnitTest, ScopedRefPtrBooleanOperations) {
scoped_refptr<SelfAssign> p1 = new SelfAssign;
scoped_refptr<SelfAssign> p2;
@@ -82,3 +84,4 @@ TEST(RefCountedUnitTest, ScopedRefPtrBooleanOperations) {
EXPECT_NE(raw_p, p2);
EXPECT_EQ(p1, p2);
}
+#endif
« base/memory/ref_counted.h ('K') | « base/memory/ref_counted.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698