Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Unified Diff: tools/telemetry/telemetry/core/platform/power_monitor/ippet_power_monitor.py

Issue 510263002: [telemetry] Disable IPPET on Windows 7. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/platform/power_monitor/ippet_power_monitor.py
diff --git a/tools/telemetry/telemetry/core/platform/power_monitor/ippet_power_monitor.py b/tools/telemetry/telemetry/core/platform/power_monitor/ippet_power_monitor.py
index 35f6030e3321126517c2007dadd2d009beaf7d46..1e63b2596a7685bc33d5671efd89280d93d6a7e0 100644
--- a/tools/telemetry/telemetry/core/platform/power_monitor/ippet_power_monitor.py
+++ b/tools/telemetry/telemetry/core/platform/power_monitor/ippet_power_monitor.py
@@ -76,10 +76,12 @@ class IppetPowerMonitor(power_monitor.PowerMonitor):
if not win32event:
return False
- windows_7_or_later = (
+ # TODO(dtu): This should work on Windows 7, but it's flaky on the bots.
+ # http://crbug.com/336558
+ windows_8_or_later = (
self._backend.GetOSName() == 'win' and
- self._backend.GetOSVersionName() >= platform_backend.WIN7)
- if not windows_7_or_later:
+ self._backend.GetOSVersionName() >= platform_backend.WIN8)
+ if not windows_8_or_later:
return False
# This check works on Windows only.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698