Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 510233002: Fix link error when use_ozone=1 and use_aura=1 (Closed)

Created:
6 years, 3 months ago by jiajia.qin
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix link error when use_ozone=1 and use_aura=1 When use_ozone=1 and use_aura=1, it will produce the following link error: obj/ui/views/widget/desktop_aura/views.desktop_native_widget_aura.o: In function `views::DesktopNativeWidgetAura::InitNativeWidget(views::Widget::InitParams const&)': desktop_native_widget_aura.cc: undefined reference to `views::DesktopCursorLoaderUpdater::Create()' R=sky@chromium.org BUG=none Committed: https://crrev.com/ac8832683dd6e5e6330c86235d510f3c00d4a620 Cr-Commit-Position: refs/heads/master@{#293070}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ui/views/views.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
jiajia.qin
sky, please help to review it.
6 years, 3 months ago (2014-08-28 03:12:03 UTC) #1
sky
Do any gn files need to be updated?
6 years, 3 months ago (2014-08-28 13:27:00 UTC) #2
jiajia.qin
On 2014/08/28 13:27:00, sky wrote: > Do any gn files need to be updated? No. ...
6 years, 3 months ago (2014-08-29 05:31:37 UTC) #3
jiajia.qin
On 2014/08/29 05:31:37, jiajia.qin wrote: > On 2014/08/28 13:27:00, sky wrote: > > Do any ...
6 years, 3 months ago (2014-09-02 07:18:40 UTC) #4
sky
LGTM
6 years, 3 months ago (2014-09-02 15:36:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiajia.qin@intel.com/510233002/1
6 years, 3 months ago (2014-09-03 01:06:56 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6f4329d9f5753cf08b81bfaa603e80efaa6a7d86
6 years, 3 months ago (2014-09-03 04:59:01 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:23:31 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac8832683dd6e5e6330c86235d510f3c00d4a620
Cr-Commit-Position: refs/heads/master@{#293070}

Powered by Google App Engine
This is Rietveld 408576698