Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 510223002: Fixed a crash while opening the file open/save dialogs on Windows 7 ASH. (Closed)

Created:
6 years, 3 months ago by ananta
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, sadrul, ben+ash_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixed a crash while opening the file open/save dialogs on Windows 7 ASH. The operations would get routed to the viewer process under the assumption that it was Windows 8 which would eventually crash while trying to open the metro dialogs which don't work on Windows 7. Fix is to return false from the ShellDialogsDelegateWin::IsWindowInMetro function for anything below Windows 8. BUG=356475 Committed: https://crrev.com/b7f1a20215d4085fe00559f9f2759d9224786c5a Cr-Commit-Position: refs/heads/master@{#292520}

Patch Set 1 #

Patch Set 2 : dir #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
ananta
ananta@chromium.org changed reviewers: + sky@chromium.org
6 years, 3 months ago (2014-08-28 01:50:58 UTC) #1
ananta
6 years, 3 months ago (2014-08-28 01:50:58 UTC) #2
sky
LGTM
6 years, 3 months ago (2014-08-28 13:24:58 UTC) #3
ananta
The CQ bit was checked by ananta@chromium.org
6 years, 3 months ago (2014-08-28 19:47:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ananta@chromium.org/510223002/1
6 years, 3 months ago (2014-08-28 19:49:10 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-28 20:43:06 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 20:53:21 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/58892)
6 years, 3 months ago (2014-08-28 20:53:22 UTC) #8
ananta
The CQ bit was checked by ananta@chromium.org
6 years, 3 months ago (2014-08-28 22:09:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ananta@chromium.org/510223002/20001
6 years, 3 months ago (2014-08-28 22:10:02 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel_swarming on tryserver.chromium.win ...
6 years, 3 months ago (2014-08-28 23:27:50 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 2b8e802b6659694752570dd1bd2f9bfbcae5d681
6 years, 3 months ago (2014-08-29 00:27:16 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:04:18 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b7f1a20215d4085fe00559f9f2759d9224786c5a
Cr-Commit-Position: refs/heads/master@{#292520}

Powered by Google App Engine
This is Rietveld 408576698