Issue 510213002: history: don't drop focus on the floor when removing a bookmark.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 510213002: history: don't drop focus on the floor when removing a bookmark. (Closed)

Created:
6 years, 3 months ago by Dan Beam

Modified:
6 years, 3 months ago

Reviewers:
dmazzoni

CC:
chromium-reviews, Patrick Dubroy, pam+watch_chromium.org, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

history: don't drop focus on the floor when removing a bookmark. R=dmazzoni@chromium.org BUG=408405 TEST=keyboard navigate to bookmark star, press space: bookmark deletes and focus still exists. Committed: https://crrev.com/7e4346c9e4ee487beffe85381eab4d4c08a45434 Cr-Commit-Position: refs/heads/master@{#293212}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -3 lines)			Patch
	M	chrome/browser/resources/history/history.css	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/browser/resources/history/history.js	View		2 chunks	+23 lines, -3 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/510213002/1

6 years, 3 months ago (2014-09-03 18:56:23 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as 09511be2ddc40b360c6d27823876709ecd13d0ec

6 years, 3 months ago (2014-09-03 23:17:45 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:28:16 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/7e4346c9e4ee487beffe85381eab4d4c08a45434
Cr-Commit-Position: refs/heads/master@{#293212}