Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 510173002: Add jbauman as OWNER of GPU process and command buffer related infrastructure. (Closed)

Created:
6 years, 3 months ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 3 months ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, jbauman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/8e8153d45e82b14384f6d2fe90c84b4350d7cbff Cr-Commit-Position: refs/heads/master@{#292262}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M content/browser/gpu/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/gpu/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M content/gpu/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/gpu/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Ken Russell (switch to Gerrit)
kbr@chromium.org changed reviewers: + piman@chromium.org
6 years, 3 months ago (2014-08-27 22:23:30 UTC) #1
Ken Russell (switch to Gerrit)
piman: PTAL. Thanks.
6 years, 3 months ago (2014-08-27 22:23:30 UTC) #2
piman
LGTM. Please keep in mind: 1- please review carefully that new code doesn't violate layering ...
6 years, 3 months ago (2014-08-27 22:27:54 UTC) #3
Ken Russell (switch to Gerrit)
The CQ bit was checked by kbr@chromium.org
6 years, 3 months ago (2014-08-27 22:29:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/510173002/1
6 years, 3 months ago (2014-08-27 22:31:06 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-27 22:43:01 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-27 22:44:09 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/9747)
6 years, 3 months ago (2014-08-27 22:44:10 UTC) #8
Ken Russell (switch to Gerrit)
The CQ bit was checked by kbr@chromium.org
6 years, 3 months ago (2014-08-27 22:54:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/510173002/20001
6 years, 3 months ago (2014-08-27 22:55:43 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-27 23:08:05 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-27 23:09:14 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/47274) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/9758) ios_rel_device ...
6 years, 3 months ago (2014-08-27 23:09:15 UTC) #13
Ken Russell (switch to Gerrit)
Crap. Somehow content/gpu/OWNERS was created with DOS-style line endings and the CQ can't handle it. ...
6 years, 3 months ago (2014-08-27 23:10:26 UTC) #14
Ken Russell (switch to Gerrit)
Committed patchset #2 (id:20001) to pending queue manually as c16c9f9 (presubmit successful).
6 years, 3 months ago (2014-08-27 23:30:56 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:55:25 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8e8153d45e82b14384f6d2fe90c84b4350d7cbff
Cr-Commit-Position: refs/heads/master@{#292262}

Powered by Google App Engine
This is Rietveld 408576698