Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 510133002: [NaCl SDK] Update build_version.ChromeVersion to return "trunk.###" (Closed)

Created:
6 years, 3 months ago by binji
Modified:
6 years, 3 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/7465b7135d712f057977e81516ec947939ad6337 Cr-Commit-Position: refs/heads/master@{#292211}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M native_client_sdk/src/build_tools/build_version.py View 2 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
binji
6 years, 3 months ago (2014-08-27 19:47:02 UTC) #1
bradn
bradnelson@google.com changed reviewers: + bradnelson@google.com
6 years, 3 months ago (2014-08-27 19:54:46 UTC) #2
bradn
lgtm
6 years, 3 months ago (2014-08-27 19:54:46 UTC) #3
binji
Committed patchset #1 (id:1) to pending queue manually as 1581c41 (presubmit successful).
6 years, 3 months ago (2014-08-27 20:09:01 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:53:39 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7465b7135d712f057977e81516ec947939ad6337
Cr-Commit-Position: refs/heads/master@{#292211}

Powered by Google App Engine
This is Rietveld 408576698