Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1599)

Unified Diff: chromeos/network/policy_util.h

Issue 510123004: Apply global auto connect ONC policy in GetManagedProperties. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/policy_util.h
diff --git a/chromeos/network/policy_util.h b/chromeos/network/policy_util.h
index c9313999335db8c44d7ce0ca5255f024d19bf4aa..cecad93e53249f899e52768367241dfed6630803 100644
--- a/chromeos/network/policy_util.h
+++ b/chromeos/network/policy_util.h
@@ -22,16 +22,33 @@ namespace policy_util {
typedef std::map<std::string, const base::DictionaryValue*> GuidToPolicyMap;
+scoped_ptr<base::DictionaryValue> CreateManagedONC(
stevenjb 2014/08/28 16:19:41 At some point we should document the "ManagedONC"
pneubeck (no reviews) 2014/08/29 16:22:21 Created a bug.
+ const base::DictionaryValue* global_policy,
+ const base::DictionaryValue* network_policy,
+ const base::DictionaryValue* user_settings,
+ const base::DictionaryValue* active_settings,
+ const NetworkProfile* profile);
+
+ // Adds properties to |properties_to_update|, which are enforced on an
+ // unamaged network by the global network config of the policy.
+ // |entry_properties| are the network's current properties read from its
+ // profile entry.
stevenjb 2014/08/28 16:19:41 Alignment
pneubeck (no reviews) 2014/08/29 16:22:21 Done.
+void SetShillPropertiesForGlobalPolicy(
+ const base::DictionaryValue& shill_dictionary,
+ const base::DictionaryValue* global_network_policy,
+ base::DictionaryValue* shill_properties_to_update);
+
// Creates a Shill property dictionary from the given arguments. The resulting
// dictionary will be sent to Shill by the caller. Depending on the profile
-// type, |policy| is interpreted as the user or device policy and |settings| as
-// the user or shared settings. |policy| or |settings| can be NULL, but not
-// both.
+// type, |network_policy| is interpreted as the user or device policy and
+// |user_settings| as the user or shared settings. |network_policy| or
+// |user_settings| can be NULL, but not both.
scoped_ptr<base::DictionaryValue> CreateShillConfiguration(
const NetworkProfile& profile,
const std::string& guid,
- const base::DictionaryValue* policy,
- const base::DictionaryValue* settings);
+ const base::DictionaryValue* global_policy,
+ const base::DictionaryValue* network_policy,
+ const base::DictionaryValue* user_settings);
// Returns the policy from |policies| matching |actual_network|, if any exists.
// Returns NULL otherwise. |actual_network| must be part of a ONC

Powered by Google App Engine
This is Rietveld 408576698