Apply global auto connect ONC policy in GetManagedProperties.

Apply global auto connect ONC policy in GetManagedProperties.

BUG=279351
Committed: https://crrev.com/fe3e74f327f252a00b0fb7c5291bd916e9feba85
Cr-Commit-Position: refs/heads/master@{#293091}

[pneubeck (no reviews), 2014-08-28 16:02:48]

pneubeck@chromium.org changed reviewers:
+ stevenjb@chromium.org

[pneubeck (no reviews), 2014-08-28 16:02:48]

picked up your CL as there was more work to make the various places consistent.

[pneubeck (no reviews), 2014-08-28 16:03:01]

On 2014/08/28 16:02:48, pneubeck wrote:
> picked up your CL as there was more work to make the various places
consistent.

... still missing some more unit_tests.

[pneubeck (no reviews), 2014-08-28 16:09:49]

I'll also have to update the function comments...

https://codereview.chromium.org/510123004/diff/1/chromeos/network/managed_net...
File chromeos/network/managed_network_configuration_handler_impl.cc (left):

https://codereview.chromium.org/510123004/diff/1/chromeos/network/managed_net...
chromeos/network/managed_network_configuration_handler_impl.cc:155: if
(profile->type() == NetworkProfile::TYPE_SHARED)
move to policy_util::CreateManagedONC

https://codereview.chromium.org/510123004/diff/1/chromeos/network/policy_appl...
File chromeos/network/policy_applicator.cc (left):

https://codereview.chromium.org/510123004/diff/1/chromeos/network/policy_appl...
chromeos/network/policy_applicator.cc:269: void
PolicyApplicator::GetPropertiesForUnmanagedEntry(
move to policy_util.cc SetShillPropertiesForGlobalPolicy

https://codereview.chromium.org/510123004/diff/1/chromeos/network/policy_util.cc
File chromeos/network/policy_util.cc (right):

https://codereview.chromium.org/510123004/diff/1/chromeos/network/policy_util...
chromeos/network/policy_util.cc:146: void ApplyGlobalAutoconnectPolicy(
this is approximately the function that you proposed.

[stevenjb, 2014-08-28 16:19:41]

Thanks for doing this. Just minor comments. I'll review again when the tests are
updated.

https://codereview.chromium.org/510123004/diff/1/chromeos/network/policy_util.cc
File chromeos/network/policy_util.cc (right):

https://codereview.chromium.org/510123004/diff/1/chromeos/network/policy_util...
chromeos/network/policy_util.cc:146: void ApplyGlobalAutoconnectPolicy(
On 2014/08/28 16:09:49, pneubeck wrote:
> this is approximately the function that you proposed.

Acknowledged.

https://codereview.chromium.org/510123004/diff/1/chromeos/network/policy_util.h
File chromeos/network/policy_util.h (right):

https://codereview.chromium.org/510123004/diff/1/chromeos/network/policy_util...
chromeos/network/policy_util.h:25: scoped_ptr<base::DictionaryValue>
CreateManagedONC(
At some point we should document the "ManagedONC" Dictionary format and refer to
that here. For now maybe add a TODO?

https://codereview.chromium.org/510123004/diff/1/chromeos/network/policy_util...
chromeos/network/policy_util.h:35: // profile entry.
Alignment

[pneubeck (no reviews), 2014-08-29 16:21:48]

Patchset #2 (id:20001) has been deleted

[pneubeck (no reviews), 2014-08-29 16:22:02]

Patchset #2 (id:40001) has been deleted

[pneubeck (no reviews), 2014-08-29 16:22:21]

is good for review now.

https://codereview.chromium.org/510123004/diff/1/chromeos/network/policy_util.h
File chromeos/network/policy_util.h (right):

https://codereview.chromium.org/510123004/diff/1/chromeos/network/policy_util...
chromeos/network/policy_util.h:25: scoped_ptr<base::DictionaryValue>
CreateManagedONC(
On 2014/08/28 16:19:41, stevenjb wrote:
> At some point we should document the "ManagedONC" Dictionary format and refer
to
> that here. For now maybe add a TODO?

Created a bug.

https://codereview.chromium.org/510123004/diff/1/chromeos/network/policy_util...
chromeos/network/policy_util.h:35: // profile entry.
On 2014/08/28 16:19:41, stevenjb wrote:
> Alignment

Done.

[stevenjb, 2014-09-02 16:26:36]

lgtm

https://codereview.chromium.org/510123004/diff/60001/chromeos/network/policy_...
File chromeos/network/policy_applicator.cc (right):

https://codereview.chromium.org/510123004/diff/60001/chromeos/network/policy_...
chromeos/network/policy_applicator.cc:318:
WriteNewShillConfiguration(*shill_dictionary, *network_policy, false);
nit: comment for 'false'

[pneubeck (no reviews), 2014-09-03 06:31:09]

Patchset #4 (id:100001) has been deleted

[pneubeck (no reviews), 2014-09-03 06:31:12]

The CQ bit was checked by pneubeck@chromium.org

[pneubeck (no reviews), 2014-09-03 06:31:16]

https://codereview.chromium.org/510123004/diff/60001/chromeos/network/policy_...
File chromeos/network/policy_applicator.cc (right):

https://codereview.chromium.org/510123004/diff/60001/chromeos/network/policy_...
chromeos/network/policy_applicator.cc:318:
WriteNewShillConfiguration(*shill_dictionary, *network_policy, false);
On 2014/09/02 16:26:35, stevenjb wrote:
> nit: comment for 'false'

Done.

[commit-bot: I haz the power, 2014-09-03 06:32:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pneubeck@chromium.org/510123004/80001

[commit-bot: I haz the power, 2014-09-03 07:28:42]

Committed patchset #3 (id:80001) as 95f37e2fbebc46130e7a031b105b92326f4f4b36

[commit-bot: I haz the power, 2014-09-10 03:24:12]

Patchset 3 (id:??) landed as
https://crrev.com/fe3e74f327f252a00b0fb7c5291bd916e9feba85
Cr-Commit-Position: refs/heads/master@{#293091}