Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 510123003: AX: Remove WebLocalFrame dependency from BlinkAXTreeSource. (Closed)

Created:
6 years, 3 months ago by tkent
Modified:
6 years, 3 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

AX: Remove WebLocalFrame dependency from BlinkAXTreeSource. This is a preparation to support AXObject in PagePopup. PagePopup doesn't have WebLocalFrame, and it's difficult to provide it. We can remove WebLocalFrame dependency of BlinkAXTreeSource by using WebDocument::scrollOffset, minimumScrollOffset, and maximumScrollOffset. This CL has no functionality changes. BUG=123896 Committed: https://crrev.com/e0ce97e9f1afa1f28c1c1261e5372d03b2af1cdb Cr-Commit-Position: refs/heads/master@{#292839}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M content/renderer/accessibility/blink_ax_tree_source.cc View 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
tkent
tkent@chromium.org changed reviewers: + dmazzoni@chromium.org
6 years, 3 months ago (2014-08-27 20:36:28 UTC) #1
tkent
dmazzoni@, would you review this please?
6 years, 3 months ago (2014-08-27 20:36:28 UTC) #2
tkent
ping dmazzoni@
6 years, 3 months ago (2014-09-01 03:14:00 UTC) #3
dmazzoni
lgtm
6 years, 3 months ago (2014-09-01 06:04:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/510123003/1
6 years, 3 months ago (2014-09-01 06:05:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8509614288db831dae8ebed7b4b429d83feed51e
6 years, 3 months ago (2014-09-01 06:40:03 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:15:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0ce97e9f1afa1f28c1c1261e5372d03b2af1cdb
Cr-Commit-Position: refs/heads/master@{#292839}

Powered by Google App Engine
This is Rietveld 408576698