LayoutTests/fast/multicol/vertical-rl/balancing/balance-trailing-border2.html - Issue 510123002: Make vertical-lr and vertical-rl versions of the tests that replace border-padding-pagination.html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/multicol/vertical-rl/balancing/balance-trailing-border2.html

Issue 510123002: Make vertical-lr and vertical-rl versions of the tests that replace border-padding-pagination.html (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Code review. Trying to express myself in English. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/multicol/vertical-lr/balancing/balance-trailing-border2.html ('K') | « LayoutTests/fast/multicol/vertical-rl/balancing/balance-trailing-border-expected.txt ('k') | LayoutTests/fast/multicol/vertical-rl/balancing/balance-trailing-border2-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/multicol/vertical-rl/balancing/balance-trailing-border2.html

diff --git a/LayoutTests/fast/multicol/balance-trailing-border2.html b/LayoutTests/fast/multicol/vertical-rl/balancing/balance-trailing-border2.html

similarity index 50%

copy from LayoutTests/fast/multicol/balance-trailing-border2.html

copy to LayoutTests/fast/multicol/vertical-rl/balancing/balance-trailing-border2.html

index 1f815e9afc40294470e788bb4c476c35e81c29f7..b04f19329bcee5895939655be6ebe0fc2aac48cf 100644

--- a/LayoutTests/fast/multicol/balance-trailing-border2.html

+++ b/LayoutTests/fast/multicol/vertical-rl/balancing/balance-trailing-border2.html

@@ -1,15 +1,15 @@

<!DOCTYPE html>

Julien - ping for review 2014/09/05 19:53:09 Same comment.

mstensho (USE GERRIT) 2014/09/09 07:45:16 Done.

-<script src="../../resources/js-test.js"></script>

+<script src="../../../../resources/js-test.js"></script>

description("Tests that the bottom border at a column boundary in a block that lives in multiple columns is recorded properly for balancing");

</script>

<p>There should be no space between the short black line and the long gray one.</p>

-<div id="mc" style="-webkit-columns:3; columns:3; line-height:21px; orphans:1; widows:1; border-bottom:3px solid gray;">

- <div style="height:9px;"></div>

- <div style="border-bottom:3px solid black;">

+<div id="mc" style="-webkit-writing-mode:vertical-rl; -webkit-columns:3; columns:3; line-height:21px; height:14em; orphans:1; widows:1; border-left:3px solid gray;">

+ <div style="width:9px;"></div>

+ <div style="border-left:3px solid black;">

</div>

- shouldBe("mc.offsetHeight", "69");

+ shouldBe("mc.offsetWidth", "69");

</script>