Reland 501823002: Used native deinterleaved and float point format for the input streams

Used native deinterleaved and float point format for the input streams.

If we call GetProperty of kAudioUnitProperty_StreamFormat before setting the format, the device will report kAudioFormatFlagsNativeFloatPacked | kLinearPCMFormatFlagIsNonInterleaved as the native format of the device, which is the same as the output.

This patch changes the format to use kAudioFormatFlagsNativeFloatPacked | kLinearPCMFormatFlagIsNonInterleaved to open the device, so that we will avoid format flipping back and forth. Hope this optimization will help increase the stability of the input audio on Mac.

TBR=DaleCurtis@chromium.org

BUG=404884
TEST=media_unittests && https://webrtc.googlecode.com/svn-history/r5497/trunk/samples/js/demos/html/pc1.html, https://www.google.com/intl/en/chrome/demos/speech.html

Committed: https://crrev.com/ebae1d3f36f0139ed578e36e21e8ac372e9424f6
Cr-Commit-Position: refs/heads/master@{#292636}

[no longer working on chromium, 2014-08-27 19:39:58]

xians@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[no longer working on chromium, 2014-08-27 19:41:37]

Patchset #2 (id:20001) has been deleted

[no longer working on chromium, 2014-08-27 19:47:25]

Hi Dale, this is a reland of https://codereview.chromium.org/501823002, the
differences between this new version and the old version are:
# alloc  sizeof(AudioBufferList) * input_params.channels() instead of
sizeof(UInt32) + input_params.channels() * sizeof(AudioBuffer) for
audio_buffer_list_, which fixed the Mac ASAN 64 bot issue.
# switch back to use audio_wrapper_, and wrapp the memory in each callback, this
handles the case when the frame size changes on the fly.

I am going to press the commit button, please stop it if you find any problem.

Thanks
SX

[no longer working on chromium, 2014-08-27 19:47:30]

The CQ bit was checked by xians@chromium.org

[commit-bot: I haz the power, 2014-08-27 19:48:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/xians@chromium.org/510073002/40001

[DaleCurtis, 2014-08-27 20:22:52]

https://codereview.chromium.org/510073002/diff/40001/media/audio/mac/audio_lo...
File media/audio/mac/audio_low_latency_input_mac.cc (right):

https://codereview.chromium.org/510073002/diff/40001/media/audio/mac/audio_lo...
media/audio/mac/audio_low_latency_input_mac.cc:87:
malloc(sizeof(AudioBufferList) * input_params.channels())));
This will oversize the buffer slightly, but should be fine. Per an Apple email
here's the recommended way:

http://lists.apple.com/archives/coreaudio-api/2005/Nov/msg00252.html

[DaleCurtis, 2014-08-27 20:22:56]

lgtm

[commit-bot: I haz the power, 2014-08-27 21:03:00]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-27 21:37:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-27 21:37:08]

Try jobs failed on following builders:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[no longer working on chromium, 2014-08-28 16:10:43]

The CQ bit was checked by xians@chromium.org

[commit-bot: I haz the power, 2014-08-28 16:12:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/xians@chromium.org/510073002/60001

[no longer working on chromium, 2014-08-28 16:12:20]

Thanks, I am going to land it soon.

https://codereview.chromium.org/510073002/diff/40001/media/audio/mac/audio_lo...
File media/audio/mac/audio_low_latency_input_mac.cc (right):

https://codereview.chromium.org/510073002/diff/40001/media/audio/mac/audio_lo...
media/audio/mac/audio_low_latency_input_mac.cc:87:
malloc(sizeof(AudioBufferList) * input_params.channels())));
On 2014/08/27 20:22:52, DaleCurtis wrote:
> This will oversize the buffer slightly, but should be fine. Per an Apple email
> here's the recommended way:
> 
> http://lists.apple.com/archives/coreaudio-api/2005/Nov/msg00252.html
> 

Thanks, I read this, and decided to go for the existing way because I was not
sure if offsetof() is available.

[commit-bot: I haz the power, 2014-08-28 17:17:34]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-28 18:00:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-28 18:00:10]

Try jobs failed on following builders:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[no longer working on chromium, 2014-08-29 13:07:14]

The CQ bit was checked by xians@chromium.org

[commit-bot: I haz the power, 2014-08-29 13:08:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/xians@chromium.org/510073002/80001

[commit-bot: I haz the power, 2014-08-29 14:13:47]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-29 15:17:35]

Committed patchset #4 (id:80001) as 2c732c000e18a6decd1da8da24e1f5f9e5f16833

[no longer working on chromium, 2014-09-03 16:44:06]

A revert of this CL (patchset #4 id:80001) has been created in
https://codereview.chromium.org/532303002/ by xians@chromium.org.

The reason for reverting is: It is speculated that this CL is blamed for
crbug/409819, I temporarily revert it to be able to verify it on canary..

[commit-bot: I haz the power, 2014-09-10 03:08:45]

Patchset 4 (id:??) landed as
https://crrev.com/ebae1d3f36f0139ed578e36e21e8ac372e9424f6
Cr-Commit-Position: refs/heads/master@{#292636}