Issue 510043002: Fix foreign tabs with > 6 navigations not showing up on Android, take 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 510043002: Fix foreign tabs with > 6 navigations not showing up on Android, take 2. (Closed)

Created:
6 years, 3 months ago by maxbogue

Modified:
6 years, 3 months ago

Reviewers:
nyquist

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Fix foreign tabs with > 6 navigations not showing up on Android, take 2. The original CL (http://crrev.com/433633002) caused crashes and was reverted; this CL only forces out-of-bounds indexes in-bounds, and leaves in the other checks. BUG=378992, 399763 Committed: https://crrev.com/4157d2b923599e800b9d867bd76dd1606d1f4887 Cr-Commit-Position: refs/heads/master@{#292237}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
	M	chrome/browser/android/foreign_session_helper.cc	View		2 chunks	+2 lines, -6 lines	0 comments	Download

Total messages: 7 (0 generated)

maxbogue

maxbogue@chromium.org changed reviewers: + nyquist@chromium.org

6 years, 3 months ago (2014-08-27 17:35:13 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maxbogue@chromium.org/510043002/1

6 years, 3 months ago (2014-08-27 21:08:37 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as a1f4ee8b27e483ccdc92852824daef4735d8c456

6 years, 3 months ago (2014-08-27 21:57:04 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:54:33 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/4157d2b923599e800b9d867bd76dd1606d1f4887
Cr-Commit-Position: refs/heads/master@{#292237}