Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 510033004: Minor history tweaks that I came across while looking at crashes. (Closed)

Created:
6 years, 3 months ago by sky
Modified:
6 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, browser-components-watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Minor history tweaks that I came across while looking at crashes. . Make HistoryService::Cleanup() private. Making this public can leave HistoryService in a bad state. . HistoryServiceFactory would leak a HistoryService if HistoryService::Init() failed. BUG=none TEST=none R=brettw@chromium.org Committed: https://crrev.com/2d5a858de159092b39950df50c46aafb876e6b56 Cr-Commit-Position: refs/heads/master@{#292382}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -73 lines) Patch
M chrome/browser/history/history_service.h View 4 chunks +13 lines, -11 lines 0 comments Download
M chrome/browser/history/history_service.cc View 2 chunks +57 lines, -57 lines 0 comments Download
M chrome/browser/history/history_service_factory.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
sky
6 years, 3 months ago (2014-08-27 23:58:52 UTC) #1
sky
sky@chromium.org changed reviewers: + brettw@chromium.org - brettw@chromium.orgt
6 years, 3 months ago (2014-08-27 23:59:02 UTC) #2
sky
This time with the right reviewer.
6 years, 3 months ago (2014-08-27 23:59:12 UTC) #3
brettw
lgtm
6 years, 3 months ago (2014-08-28 04:50:22 UTC) #4
sky
The CQ bit was checked by sky@chromium.org
6 years, 3 months ago (2014-08-28 13:08:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/510033004/1
6 years, 3 months ago (2014-08-28 13:09:20 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-28 14:03:00 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as bcfedb750dbb567f4894419db807cc9f5486e019
6 years, 3 months ago (2014-08-28 14:56:06 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:59:34 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d5a858de159092b39950df50c46aafb876e6b56
Cr-Commit-Position: refs/heads/master@{#292382}

Powered by Google App Engine
This is Rietveld 408576698