Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 510033002: Print function scopes with indents. (Closed)

Created:
6 years, 3 months ago by Michael Lippautz (Google)
Modified:
6 years, 3 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Print function scopes with indents. BUG= R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=39614

Patch Set 1 #

Patch Set 2 : add newline before first parameter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -13 lines) Patch
M runtime/vm/ast_printer.h View 1 chunk +7 lines, -2 lines 0 comments Download
M runtime/vm/ast_printer.cc View 1 4 chunks +25 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Lippautz (Google)
mlippautz@google.com changed reviewers: + hausner@google.com
6 years, 3 months ago (2014-08-27 17:20:32 UTC) #1
Michael Lippautz (Google)
It takes up more space but is actually readable. Example: Scope for function 'dart:core_Uri__makeHost@915557746' {scope ...
6 years, 3 months ago (2014-08-27 17:20:32 UTC) #2
Michael Lippautz (Google)
Added one more newline before first parameter. Example: Scope for function 'dart:core_Uri__makeHost@915557746' {scope 0xffec6da8 llev ...
6 years, 3 months ago (2014-08-27 17:25:27 UTC) #3
hausner
lgtm
6 years, 3 months ago (2014-08-27 18:12:15 UTC) #4
Michael Lippautz (Google)
6 years, 3 months ago (2014-08-27 18:47:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 39614 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698