Issue 51003007: Make it possible to pass GYP_DEFINES to Android builds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 51003007: Make it possible to pass GYP_DEFINES to Android builds (Closed)

Created:
7 years, 1 month ago by Kimmo Kinnunen

Modified:
7 years, 1 month ago

Reviewers:
djsollen

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Make it possible to pass GYP_DEFINES to Android builds Pass possibly existing GYP_DEFINES from shell to gyp when building for Android. Makes it possible to use custom build flags such as skia_nv_path_rendering=1. Committed: http://code.google.com/p/skia/source/detail?r=12128

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	platform_tools/android/bin/android_setup.sh	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kkinnunen@nvidia.com/51003007/1

7 years, 1 month ago (2013-11-05 06:03:08 UTC) #3

Message was sent while issue was closed.

Change committed as 12128

Expand Messages | Collapse Messages