Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 510023003: [Android] Allow passing in extra intent flags for share menu item. (Closed)

Created:
6 years, 3 months ago by aurimas (slooooooooow)
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Allow passing in extra intent flags for share menu item. BUG=409104 b/17294369 NOTRY=true Committed: https://crrev.com/2ef4b8517994a4d9fef7c46fa37e4901ed4b6fd6 Cr-Commit-Position: refs/heads/master@{#293015}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated javadoc #

Patch Set 3 : Rebase #

Patch Set 4 : #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -12 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java View 1 6 chunks +17 lines, -11 lines 0 comments Download
M chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
aurimas (slooooooooow)
aurimas@chromium.org changed reviewers: + dtrainor@chromium.org
6 years, 3 months ago (2014-08-28 01:25:14 UTC) #1
aurimas (slooooooooow)
PTAL
6 years, 3 months ago (2014-08-28 01:25:14 UTC) #2
David Trainor- moved to gerrit
javadoc nit but lgtm https://chromiumcodereview.appspot.com/510023003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java File chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java (right): https://chromiumcodereview.appspot.com/510023003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java#newcode59 chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java:59: public static void share(boolean shareDirectly, ...
6 years, 3 months ago (2014-08-28 15:28:13 UTC) #3
aurimas (slooooooooow)
https://chromiumcodereview.appspot.com/510023003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java File chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java (right): https://chromiumcodereview.appspot.com/510023003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java#newcode59 chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java:59: public static void share(boolean shareDirectly, Activity activity, String title, ...
6 years, 3 months ago (2014-08-28 16:33:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/510023003/80001
6 years, 3 months ago (2014-09-02 21:10:55 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-09-02 22:27:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/510023003/80001
6 years, 3 months ago (2014-09-02 22:36:02 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001) as 1820ccaaf5de11dcf23e3a643d3489962d9608ac
6 years, 3 months ago (2014-09-02 22:49:03 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:21:32 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/2ef4b8517994a4d9fef7c46fa37e4901ed4b6fd6
Cr-Commit-Position: refs/heads/master@{#293015}

Powered by Google App Engine
This is Rietveld 408576698