Issue 509993002: Downgrade all CHECKs to DCHECKs in SimpleCache backend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 509993002: Downgrade all CHECKs to DCHECKs in SimpleCache backend. (Closed)

Created:
6 years, 3 months ago by gavinp

Modified:
6 years, 2 months ago

Reviewers:
Deprecated (see juliatuttle)

CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Downgrade all CHECKs to DCHECKs in SimpleCache backend. After we're sure we have fixed 317138, let's drop these CHECKs. Also, celebrate! R=ttuttle@chromium.org BUG=317138 Committed: https://crrev.com/0f5b57907d87fbd5692f00d414d69fb86ba4f1df Cr-Commit-Position: refs/heads/master@{#296972}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -11 lines)			Patch
	M	net/disk_cache/simple/simple_backend_impl.cc	View		3 chunks	+5 lines, -11 lines	0 comments	Download

Total messages: 6 (1 generated)

gavinp

ttuttle: Let's not land this right away, but after we have good signal from beta ...

6 years, 3 months ago (2014-08-27 15:04:00 UTC) #1

Deprecated (see juliatuttle)

On 2014/08/27 15:04:00, gavinp wrote: > ttuttle: Let's not land this right away, but after ...

6 years, 3 months ago (2014-08-28 13:54:41 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/509993002/1

6 years, 2 months ago (2014-09-26 16:48:35 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as 2c44702e3fac174124fabffc211cce82b80efed9

6 years, 2 months ago (2014-09-26 17:44:16 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-09-26 17:44:59 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/0f5b57907d87fbd5692f00d414d69fb86ba4f1df
Cr-Commit-Position: refs/heads/master@{#296972}