Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 509973002: New SimpleCache Entry test for duplicate dooms. (Closed)

Created:
6 years, 3 months ago by gavinp
Modified:
6 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org
Project:
chromium
Visibility:
Public.

Description

New SimpleCache Entry test for duplicate dooms. Adds a regression test for bug 317138. This test is interesting because it generates exactly the same stacks that we're seeing in crash reports on that bug. This is a good regression test, so I suggest we land it, as well as look at it for more confidence that our fix to bug 317138 is the right fix. R=ttuttle@chromium.org,jkarlin@chromium.org BUG=317138 Committed: https://crrev.com/219ac0b8461239768efa1cad3bca720bbaf065d1 Cr-Commit-Position: refs/heads/master@{#292399}

Patch Set 1 #

Patch Set 2 : cleanup comment #

Patch Set 3 : less dumb #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -0 lines) Patch
M net/disk_cache/entry_unittest.cc View 1 2 1 chunk +64 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
gavinp
ttuttle: PTAL. jkarlin: FYI. Awesome discovery by you!!!
6 years, 3 months ago (2014-08-27 14:59:19 UTC) #1
Deprecated (see juliatuttle)
On 2014/08/27 14:59:19, gavinp wrote: > ttuttle: PTAL. > > jkarlin: FYI. Awesome discovery by ...
6 years, 3 months ago (2014-08-28 13:53:51 UTC) #2
gavinp
The CQ bit was checked by gavinp@chromium.org
6 years, 3 months ago (2014-08-28 15:33:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/509973002/40001
6 years, 3 months ago (2014-08-28 15:33:53 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_arm64_dbg_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-28 16:29:35 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as dc3ffa12e082ca7f21e411759f48b41007163cee
6 years, 3 months ago (2014-08-28 16:48:38 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:00:07 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/219ac0b8461239768efa1cad3bca720bbaf065d1
Cr-Commit-Position: refs/heads/master@{#292399}

Powered by Google App Engine
This is Rietveld 408576698