Oilpan: Move MediaStreamSource, MediaStreamComponent and MediaStreamDescriptor to oilpan's heap

public/platform/WebMediaStreamSource.h

Index: public/platform/WebMediaStreamSource.h
diff --git a/public/platform/WebMediaStreamSource.h b/public/platform/WebMediaStreamSource.h
index 58692287a9b053c1c168ca058d7ecd6d8fdf621f..d098de066fb1c3ac198c138b0d6c2e7f152aadd1 100644
--- a/public/platform/WebMediaStreamSource.h
+++ b/public/platform/WebMediaStreamSource.h
@@ -35,6 +35,9 @@
 #include "WebNonCopyable.h"
 #include "WebPrivatePtr.h"
 #include "WebVector.h"
+#if INSIDE_BLINK
+#include "platform/heap/Handle.h"
+#endif
 
 namespace blink {
 
@@ -57,6 +60,9 @@ public:
 #endif
 
     private:
+#if INSIDE_BLINK
+        GC_PLUGIN_IGNORE("")
+#endif
         MediaStreamSource* m_owner;

[haraken, 2014/08/27 12:33:56]

I'm not sure if I'm doing a right thing here.

- Because ExtraData is a web-exposed class, we cannot make the ExtraData derive
GarbageCollected.

- We cannot use Persistent<MediaStreamSource>, because it can cause a cycle (we
cannot assume nothing about the lifetime of ExtraData objects in the embedder
side).

- If we don't add INSIDE_BLINK, it causes a lot of compile errors.

- Given the above, I used a raw pointer for m_owner.

[zerny-chromium, 2014/08/27 13:21:53]

This raw pointer looks very unsafe, but is no more unsafe than in the non-oilpan
build (given that ExtaData is referenced by an OwnPtr from MediaStreamSource).

[tkent, 2014/09/01 06:59:46]

Resolving this raw pointer needs a lot of work, and I don't think it's worth to
do it now. Let's keep the raw pointer.

[haraken, 2014/09/01 07:10:44]

Thanks, I filed a bug and added the bug number to GC_PLUGIN_IGNORE.

     };
 
@@ -111,9 +117,8 @@ public:
     BLINK_PLATFORM_EXPORT bool removeAudioConsumer(WebAudioDestinationConsumer*);
 
 #if INSIDE_BLINK
-    BLINK_PLATFORM_EXPORT WebMediaStreamSource(const WTF::PassRefPtr<MediaStreamSource>&);
+    BLINK_PLATFORM_EXPORT WebMediaStreamSource(MediaStreamSource*);
     BLINK_PLATFORM_EXPORT WebMediaStreamSource& operator=(MediaStreamSource*);
-    BLINK_PLATFORM_EXPORT operator WTF::PassRefPtr<MediaStreamSource>() const;
     BLINK_PLATFORM_EXPORT operator MediaStreamSource*() const;
 #endif