chrome/browser/about_flags.h - Issue 509923003: about_flags::ReportCustomFlags() should use signed 32-bit IDs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/about_flags.h

Issue 509923003: about_flags::ReportCustomFlags() should use signed 32-bit IDs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update after review. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/about_flags.h

diff --git a/chrome/browser/about_flags.h b/chrome/browser/about_flags.h

index 7a229a7e140326c481505d797361c76725ede75d..9a4396e2377ce42026233cc27d193a450014d667 100644

--- a/chrome/browser/about_flags.h

+++ b/chrome/browser/about_flags.h

@@ -26,7 +26,7 @@ class FlagsStorage;

// This value is reported as switch histogram ID if switch name has unknown

// format.

-extern const uint32_t kBadSwitchFormatHistogramId;

+extern const int32_t kBadSwitchFormatHistogramId;

// Enumeration of OSs.

// This is exposed only for testing.

@@ -171,7 +171,7 @@ int GetCurrentPlatform();

void RecordUMAStatistics(FlagsStorage* flags_storage);

// Returns the UMA id for the specified switch name.

-uint32_t GetSwitchUMAId(const std::string& switch_name);

+int32_t GetSwitchUMAId(const std::string& switch_name);

sky 2014/09/02 17:13:22 How come you aren't using base::HistogramBase::Sa

Alexander Alekseev 2014/09/02 17:59:32 Done. Sorry, I missed it.

// Sends stats (as UMA histogram) about command_line_difference.

// This is used on ChromeOS to report flags that lead to browser restart.

« no previous file with comments | « no previous file | chrome/browser/about_flags.cc » ('j') | no next file with comments »