Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 509873002: Refactor MediaStreamTrack video onmute event. (Closed)

Created:
6 years, 3 months ago by perkj_chrome
Modified:
6 years, 3 months ago
Reviewers:
mcasas
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Refactor MediaStreamTrack video onmute event. This changes monitoring of video frames delivered to MediaStreamVideoSource to be started when the source is started and stopped when the source is stopped rather than depend on that the source object is destroyed since destruction is dependent on when blink runs garbage collection. It removes the unused MediaStreamVideoTrack::SetMuted and GetMuted. It reduces the need for a thread hop between the io-thread and the render thread for each monitor intervall by only trigger the monitoring callback on if a change has occured. It reduces the test time of media_stream_video_source_unittest.cc from more than 7s to around 200ms. BUG=404106 Committed: https://crrev.com/530c4af7cd8af97421b7aaa215ee893c1f6d6e14 Cr-Commit-Position: refs/heads/master@{#292853}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Rebased #

Patch Set 4 : Fixed nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -136 lines) Patch
M content/renderer/media/media_stream_track.h View 1 2 4 chunks +3 lines, -9 lines 0 comments Download
M content/renderer/media/media_stream_track.cc View 1 2 2 chunks +1 line, -11 lines 0 comments Download
M content/renderer/media/media_stream_video_source.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/media_stream_video_source.cc View 1 2 6 chunks +10 lines, -18 lines 0 comments Download
M content/renderer/media/media_stream_video_source_unittest.cc View 1 2 3 3 chunks +27 lines, -61 lines 0 comments Download
M content/renderer/media/media_stream_video_track.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/media/media_stream_video_track.cc View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M content/renderer/media/mock_media_stream_video_source.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/video_track_adapter.h View 1 4 chunks +18 lines, -4 lines 0 comments Download
M content/renderer/media/video_track_adapter.cc View 1 2 7 chunks +50 lines, -19 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
perkj_chrome
perkj@chromium.org changed reviewers: + mcasas@chromium.org
6 years, 3 months ago (2014-08-27 10:00:53 UTC) #1
perkj_chrome
Hej Can you please review?
6 years, 3 months ago (2014-08-27 10:00:54 UTC) #2
perkj_chrome
Hej Can you please review?
6 years, 3 months ago (2014-08-27 10:00:55 UTC) #3
mcasas
Big cleanup! Make sure it works and otherwise LGTM. In my defense, I thought that ...
6 years, 3 months ago (2014-08-27 12:52:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/perkj@chromium.org/509873002/60001
6 years, 3 months ago (2014-09-01 07:31:50 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-09-01 08:33:06 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 9544ba9cc78bb9dc26b2ee37485ee17db6a49a32
6 years, 3 months ago (2014-09-01 08:58:40 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:16:13 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/530c4af7cd8af97421b7aaa215ee893c1f6d6e14
Cr-Commit-Position: refs/heads/master@{#292853}

Powered by Google App Engine
This is Rietveld 408576698