Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 509863002: Remove python bindings unittests from the build. (Closed)

Created:
6 years, 3 months ago by qsr
Modified:
6 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove python bindings unittests from the build. Instead add a run_mojo_python_bindings_tests.py that will be run from the bots. This also refactor run_mojo_python_tests.py to factorize the common code. BUG=407818 Committed: https://crrev.com/b5d3236c107c3c1972657c2a832c379a8bd5b903 Cr-Commit-Position: refs/heads/master@{#292372}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -491 lines) Patch
M mojo/mojo.gyp View 1 chunk +0 lines, -23 lines 0 comments Download
M mojo/python/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download
D mojo/python/tests/BUILD.gn View 1 chunk +0 lines, -24 lines 0 comments Download
A + mojo/python/tests/system_unittest.py View 1 chunk +0 lines, -4 lines 0 comments Download
D mojo/python/tests/test_core.py View 1 chunk +0 lines, -314 lines 0 comments Download
A mojo/tools/pylib/mojo_python_tests_runner.py View 1 chunk +147 lines, -0 lines 0 comments Download
A mojo/tools/run_mojo_python_bindings_tests.py View 1 chunk +34 lines, -0 lines 0 comments Download
M mojo/tools/run_mojo_python_tests.py View 1 chunk +7 lines, -121 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
qsr
qsr@chromium.org changed reviewers: + dpranke@chromium.org
6 years, 3 months ago (2014-08-27 09:50:21 UTC) #1
qsr
6 years, 3 months ago (2014-08-27 09:50:21 UTC) #2
Dirk Pranke
lgtm. basically seems fine. I'm hoping to eventually remove all of this code in favor ...
6 years, 3 months ago (2014-08-28 00:32:02 UTC) #3
qsr
Thanks. Having a generic test runner would be great.
6 years, 3 months ago (2014-08-28 08:26:17 UTC) #4
qsr
The CQ bit was checked by qsr@chromium.org
6 years, 3 months ago (2014-08-28 08:26:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/509863002/1
6 years, 3 months ago (2014-08-28 08:27:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as db59690977a81bcb2e287d494925db0d9659b3b5
6 years, 3 months ago (2014-08-28 12:59:57 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:59:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5d3236c107c3c1972657c2a832c379a8bd5b903
Cr-Commit-Position: refs/heads/master@{#292372}

Powered by Google App Engine
This is Rietveld 408576698