Code refactor related to WeakPtrFactory in src/sync module

Changing the order of weak_ptr_factory in src/sync module, to ensure proper cleanup while object is inactive.

BUG=303818
Committed: https://crrev.com/0e6caf9065d630ef1155a4b1034a725c72fb13c6
Cr-Commit-Position: refs/heads/master@{#293678}

[MRV, 2014-08-27 09:18:21]

mohan.reddy@samsung.com changed reviewers:
+ l.gombos@samsung.com, vivek.vg@samsung.com

[MRV, 2014-08-28 03:09:43]

mohan.reddy@samsung.com changed reviewers:
+ rsimha@chromium.org
- l.gombos@samsung.com, vivek.vg@samsung.com

[MRV, 2014-08-28 03:09:43]

rsimha@chromium.org: Please review changes in src/sync module

[MRV, 2014-08-28 04:15:37]

mohan.reddy@samsung.com changed reviewers:
+ rlarocque@chromium.org

[MRV, 2014-08-28 04:15:54]

On 2014/08/28 04:15:37, MRV wrote:
> mailto:mohan.reddy@samsung.com changed reviewers:
> + mailto:rlarocque@chromium.org

PTAL

[rlarocque, 2014-08-28 16:58:37]

rlarocque@chromium.org changed reviewers:
+ haitaol@chromium.org

[rlarocque, 2014-08-28 16:58:37]

Sorry, I'm not actively working on Chrome anymore.  Neither is rsimha.

+Haitao for review.

[haitaol1, 2014-08-28 17:28:28]

On 2014/08/28 16:58:37, rlarocque wrote:
> Sorry, I'm not actively working on Chrome anymore.  Neither is rsimha.
> 
> +Haitao for review.

mrv@: I'm not sure about AUTHORS (myself is not even in it). Can you move it to
a separate patch?

[rlarocque, 2014-08-28 17:30:17]

On 2014/08/28 17:28:28, haitaol1 wrote:
> On 2014/08/28 16:58:37, rlarocque wrote:
> > Sorry, I'm not actively working on Chrome anymore.  Neither is rsimha.
> > 
> > +Haitao for review.
> 
> mrv@: I'm not sure about AUTHORS (myself is not even in it). Can you move it
to
> a separate patch?

He's right to do so.  See http://www.chromium.org/developers/contributing-code
and
http://www.chromium.org/developers/contributing-code/external-contributor-che....

[lgombos, 2014-08-28 17:31:37]

l.gombos@samsung.com changed reviewers:
+ pdr@chromium.org

[lgombos, 2014-08-28 17:31:37]

Perhaps @pdr can help review the AUTHORS file change.

[haitaol1, 2014-08-28 17:33:35]

lgtm

I see. LGTM

[haitaol1, 2014-08-28 17:33:36]

lgtm

lgtm

I see. LGTM

[pdr., 2014-08-28 20:55:23]

On 2014/08/28 17:33:36, haitaol1 wrote:
> lgtm
> 
> lgtm
> 
> I see. LGTM

Authors file LGTM (I verified MRV is listed in the cla signers file).

[pdr., 2014-08-28 21:00:58]

I know nothing about this area of the code but code changes with behavior
changes but no tests scare me. Is this change testable? In what case did the
destructor order matter?

[MRV, 2014-09-01 02:57:59]

On 2014/08/28 21:00:58, pdr wrote:
> I know nothing about this area of the code but code changes with behavior
> changes but no tests scare me. Is this change testable? In what case did the
> destructor order matter?
@pdr, Please find my answers to your queries below:
WeakPtrFactory's documentation says:
1. Member variables should appear before the WeakPtrFactory, to ensure that any
WeakPtrs to Controller are invalidated before its members variable's destructors
are executed, rendering them invalid.
2. This is because members are destructed in reverse-order that they appear in
the class definition.

[MRV, 2014-09-01 11:03:58]

mohan.reddy@samsung.com changed reviewers:
+ dmichael@chromium.org

[MRV, 2014-09-03 02:41:24]

The CQ bit was checked by mohan.reddy@samsung.com

[MRV, 2014-09-03 02:41:54]

The CQ bit was unchecked by mohan.reddy@samsung.com

[MRV, 2014-09-03 14:34:34]

@pdr, PTAL

[pdr., 2014-09-03 17:07:12]

On 2014/09/03 14:34:34, MRV wrote:
> @pdr, PTAL

OK LGTM

[MRV, 2014-09-08 03:34:55]

The CQ bit was checked by mohan.reddy@samsung.com

[commit-bot: I haz the power, 2014-09-08 03:35:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mohan.reddy@samsung.com/509853003/20001

[MRV, 2014-09-08 06:05:16]

Thanks pdr and haitaol1 for LGTM

[MRV, 2014-09-08 06:05:18]

Thanks pdr and haitaol1 for LGTM

[commit-bot: I haz the power, 2014-09-08 06:55:47]

Committed patchset #2 (id:20001) as c30a9dea262b2e39d1c9b761379ce30682a64d6e

[commit-bot: I haz the power, 2014-09-10 03:44:47]

Patchset 2 (id:??) landed as
https://crrev.com/0e6caf9065d630ef1155a4b1034a725c72fb13c6
Cr-Commit-Position: refs/heads/master@{#293678}