Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: sdk/lib/core/bool.dart

Issue 50983002: Implement fromEnvironment on bool, int and String (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/core/bool.dart
diff --git a/sdk/lib/core/bool.dart b/sdk/lib/core/bool.dart
index 6c7797fc4cb3be57f6fefaef74996aee1095a03e..c4348b7117300303f2ebc949c16a18562749f707 100644
--- a/sdk/lib/core/bool.dart
+++ b/sdk/lib/core/bool.dart
@@ -12,10 +12,11 @@ part of dart.core;
* bool.
*/
class bool {
- factory bool._uninstantiable() {
- throw new UnsupportedError(
- "class bool cannot be instantiated");
- }
+ /**
+ * Returns the boolean for the given environment variable [name] or
+ * [defaultValue] if [name] is not present.
+ */
+ external const factory bool.fromEnvironment(String name, {bool defaultValue});
Lasse Reichstein Nielsen 2013/10/31 06:55:38 I still think the default is silly, but if it is t
/**
* Returns [:"true":] if the receiver is [:true:], or [:"false":] if the

Powered by Google App Engine
This is Rietveld 408576698