Implement fromEnvironment on bool, int and String

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/cpu.h"
@@ skipping 12357 matching lines @@
     ASSERT(!BigintOperations::FitsIntoInt64(big));
     return big.raw();
   }
   if ((value <= Smi::kMaxValue) && (value >= Smi::kMinValue)) {
     return Smi::New(value);
   }
   return Mint::NewCanonical(value);
 }
 
 
+RawInteger* Integer::NewCanonical(int64_t value) {

[Ivan Posva, 2013/10/29 21:42:59]

Please remove as this is not needed anywhere as far as I understand.

[Søren Gjesse, 2013/10/30 11:44:02]

Done.

+  if ((value <= Smi::kMaxValue) && (value >= Smi::kMinValue)) {
+    return Smi::New(value);
+  }
+  return Mint::NewCanonical(value);
+}
+
 // dart2js represents integers as double precision floats, which can represent
 // anything in the range -2^53 ... 2^53.
 static bool IsJavascriptInt(int64_t value) {
   return ((-0x20000000000000LL <= value) && (value <= 0x20000000000000LL));
 }
 
 
 RawInteger* Integer::New(int64_t value, Heap::Space space, const bool silent) {
   if ((value <= Smi::kMaxValue) && (value >= Smi::kMinValue)) {
     return Smi::New(value);
@@ skipping 3196 matching lines @@
   return "_MirrorReference";
 }
 
 
 void MirrorReference::PrintToJSONStream(JSONStream* stream, bool ref) const {
   JSONObject jsobj(stream);
 }
 
 
 }  // namespace dart