components/nacl/loader/nonsfi/nonsfi_sandbox.cc - Issue 509783003: Non-SFI NaCl: Allow openat system call to gracefully fail on BareMetal seccomp-bpf.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/loader/nonsfi/nonsfi_sandbox.cc

Issue 509783003: Non-SFI NaCl: Allow openat system call to gracefully fail on BareMetal seccomp-bpf. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix unit test Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/nacl/loader/nonsfi/nonsfi_sandbox.cc

diff --git a/components/nacl/loader/nonsfi/nonsfi_sandbox.cc b/components/nacl/loader/nonsfi/nonsfi_sandbox.cc

index 35ee417d2051e2ddfb720f879e7d0e5c86ce8382..b5fe899746c3bc7a70b62193ccc693766e917216 100644

--- a/components/nacl/loader/nonsfi/nonsfi_sandbox.cc

+++ b/components/nacl/loader/nonsfi/nonsfi_sandbox.cc

@@ -162,8 +162,10 @@ bool IsGracefullyDenied(int sysno) {

// tcmalloc calls madvise in TCMalloc_SystemRelease.

case __NR_madvise:

// EPERM instead of SIGSYS as glibc tries to open files in /proc.

+ // openat via opendir via get_nprocs_conf and open via get_nprocs.

// TODO(hamaji): Remove this when we switch to newlib.

case __NR_open:

+ case __NR_openat:

// For RunSandboxSanityChecks().

case __NR_ptrace:

// glibc uses this for its pthread implementation. If we return

« no previous file with comments | « no previous file | components/nacl/loader/nonsfi/nonsfi_sandbox_sigsys_unittest.cc » ('j') | no next file with comments »