Introduce @CalledByReflection annotation.

Introduce @CalledByReflection annotation.

BUG=163393
Committed: https://crrev.com/0f9a254ee1378da9707334fb858ffe642d1af878
Cr-Commit-Position: refs/heads/master@{#292394}

[aurimas (slooooooooow), 2014-08-26 23:44:51]

aurimas@chromium.org changed reviewers:
+ yfriedman@chromium.org

[aurimas (slooooooooow), 2014-08-26 23:44:51]

PTAL

[aurimas (slooooooooow), 2014-08-26 23:51:49]

aurimas@chromium.org changed reviewers:
+ tedchoc@chromium.org

[aurimas (slooooooooow), 2014-08-26 23:51:49]

+tedchoc as FYI

[Yaron, 2014-08-27 00:19:12]

yfriedman@chromium.org changed reviewers:
+ mef@chromium.org

[Yaron, 2014-08-27 00:19:12]

I just remembered that cronet added something similar a while back:
https://codereview.chromium.org/183333002

The original cl had it in base and I objected because it seemed like a bad
precedent that we didn't want. Given there's the OEM use case now as well, I'm
fine with moving that one to base.
mef: any objections?

[mef, 2014-08-27 00:31:46]

On 2014/08/27 00:19:12, Yaron wrote:
> I just remembered that cronet added something similar a while back:
> https://codereview.chromium.org/183333002
> 
> The original cl had it in base and I objected because it seemed like a bad
> precedent that we didn't want. Given there's the OEM use case now as well, I'm
> fine with moving that one to base.
> mef: any objections?

I have no objections, and I also have a question: is it possible to specify a
custom proguard config for java or java_apk project?

[Yaron, 2014-08-27 00:36:28]

On 2014/08/27 00:31:46, mef wrote:
> On 2014/08/27 00:19:12, Yaron wrote:
> > I just remembered that cronet added something similar a while back:
> > https://codereview.chromium.org/183333002
> > 
> > The original cl had it in base and I objected because it seemed like a bad
> > precedent that we didn't want. Given there's the OEM use case now as well,
I'm
> > fine with moving that one to base.
> > mef: any objections?
> 
> I have no objections, and I also have a question: is it possible to specify a
> custom proguard config for java or java_apk project?

I believe so, yes. build/android/tests/multiple_proguards/multiple_proguards.gyp
is an example of doing it an apk level. third_party/guava/guava.gyp does it for
a library.

[mef, 2014-08-27 14:29:38]

On 2014/08/27 00:36:28, Yaron wrote:
> On 2014/08/27 00:31:46, mef wrote:
> > On 2014/08/27 00:19:12, Yaron wrote:
> > > I just remembered that cronet added something similar a while back:
> > > https://codereview.chromium.org/183333002
> > > 
> > > The original cl had it in base and I objected because it seemed like a bad
> > > precedent that we didn't want. Given there's the OEM use case now as well,
> I'm
> > > fine with moving that one to base.
> > > mef: any objections?
> > 
> > I have no objections, and I also have a question: is it possible to specify
a
> > custom proguard config for java or java_apk project?
> 
> I believe so, yes.
build/android/tests/multiple_proguards/multiple_proguards.gyp
> is an example of doing it an apk level. third_party/guava/guava.gyp does it
for
> a library.

Perfect, thanks!

[aurimas (slooooooooow), 2014-08-27 23:20:25]

Please take another look at this CL. I moved the existing annotation.

[Yaron, 2014-08-27 23:41:53]

lgtm

https://chromiumcodereview.appspot.com/509753002/diff/40001/content/public/an...
File
content/public/android/java/src/org/chromium/content/browser/SmartClipProvider.java
(right):

https://chromiumcodereview.appspot.com/509753002/diff/40001/content/public/an...
content/public/android/java/src/org/chromium/content/browser/SmartClipProvider.java:18:
@UsedByReflection("ExternalSamsung")
Nit: ExternalOemSupport (throughout)

[aurimas (slooooooooow), 2014-08-27 23:57:55]

mef: WDYT?

[aurimas (slooooooooow), 2014-08-27 23:57:56]

mef: WDYT?

[mef, 2014-08-28 15:04:05]

lgtm

[aurimas (slooooooooow), 2014-08-28 15:19:40]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2014-08-28 15:20:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aurimas@chromium.org/509753002/60001

[commit-bot: I haz the power, 2014-08-28 16:15:43]

Committed patchset #4 (id:60001) as 245acf7afd2d3b3fe308d61147268318c26899a5

[commit-bot: I haz the power, 2014-09-10 02:59:58]

Patchset 4 (id:??) landed as
https://crrev.com/0f9a254ee1378da9707334fb858ffe642d1af878
Cr-Commit-Position: refs/heads/master@{#292394}