Fix a bug when looping through m_pCompData

Fix a bug when looping through m_pCompData

BUG=408154
R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/a67da71

[Bo Xu, 2014-08-27 19:24:56]

bo_xu@foxitsoftware.com changed reviewers:
+ jun_fang@foxitsoftware.com, tsepez@chromium.org

[Bo Xu, 2014-08-27 19:24:57]

Hi, Tom, please review.

[Tom Sepez, 2014-08-27 19:32:49]

On 2014/08/27 19:24:57, Bo Xu wrote:
> Hi, Tom, please review.
LGTM.

If there is a bug # for this issue, please add a

BUG=

line to the description for this patch.

[Bo Xu, 2014-08-27 19:35:00]

On 2014/08/27 19:32:49, Tom Sepez wrote:
> On 2014/08/27 19:24:57, Bo Xu wrote:
> > Hi, Tom, please review.
> LGTM.
> 
> If there is a bug # for this issue, please add a
> 
> BUG=
> 
> line to the description for this patch.

Thanks Tom. The "BUG=408154" was there, maybe it's not showing on your side?

[Tom Sepez, 2014-08-27 19:48:01]

Thanks Tom. The "BUG=408154" was there, maybe it's not showing on your side?

Ah, now it is.  Not sure what happened there.  Also note that I checked through
this file for other places where this array might be mis-indexed.  They look OK,
though in looking at the code, a good follow-up would be to rewrite the loop at
line 545 in a saner manner for posterity. e.g.

               for (FX_DWORD i = 0; i < m_nComponents; i ++) {
                        m_pCompData[i].m_ColorKeyMin = pArray->GetInteger(2 *
i);
                        m_pCompData[i].m_ColorKeyMax = pArray->GetInteger(2 * i
+ 1);
                }

[Bo Xu, 2014-08-27 20:13:19]

On 2014/08/27 19:48:01, Tom Sepez wrote:
> Thanks Tom. The "BUG=408154" was there, maybe it's not showing on your side?
> 
> Ah, now it is.  Not sure what happened there.  Also note that I checked
through
> this file for other places where this array might be mis-indexed.  They look
OK,
> though in looking at the code, a good follow-up would be to rewrite the loop
at
> line 545 in a saner manner for posterity. e.g.
> 
>                for (FX_DWORD i = 0; i < m_nComponents; i ++) {
>                         m_pCompData[i].m_ColorKeyMin = pArray->GetInteger(2 *
> i);
>                         m_pCompData[i].m_ColorKeyMax = pArray->GetInteger(2 *
i
> + 1);
>                 }

I will do this in a separate patch.

[Bo Xu, 2014-08-27 20:13:48]

Committed patchset #1 (id:1) manually as a67da71 (presubmit successful).