Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: chrome/browser/prerender/prerender_tracker.cc

Issue 509573002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/prerender/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prerender/prerender_local_predictor.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_tracker.cc
diff --git a/chrome/browser/prerender/prerender_tracker.cc b/chrome/browser/prerender/prerender_tracker.cc
index cabb35b44b09a00dda368857adb47598aba471c8..d362e838afc02648193e2682f359b09ea12aa8c2 100644
--- a/chrome/browser/prerender/prerender_tracker.cc
+++ b/chrome/browser/prerender/prerender_tracker.cc
@@ -166,7 +166,7 @@ void PrerenderTracker::RemovePrerenderCookieStoreOnIOThread(int process_id,
for (std::vector<GURL>::const_iterator url_it = cookie_change_urls.begin();
url_it != cookie_change_urls.end();
++url_it) {
- OnCookieChangedForURL(process_id, cookie_monster, *url_it);
+ OnCookieChangedForURL(process_id, cookie_monster.get(), *url_it);
}
}
@@ -175,7 +175,7 @@ void PrerenderTracker::AddPrerenderCookieStoreOnIOThread(
scoped_refptr<net::URLRequestContextGetter> request_context,
const base::Closure& cookie_conflict_cb) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
- DCHECK(request_context != NULL);
+ DCHECK(request_context.get() != NULL);
gavinp 2014/08/27 17:30:21 Nit: DCHECK_NE?
dcheng 2014/08/27 17:57:34 DCHECK_NE(foo, NULL) actually doesn't compile, sin
net::CookieMonster* cookie_monster =
request_context->GetURLRequestContext()->cookie_store()->
GetCookieMonster();
« no previous file with comments | « chrome/browser/prerender/prerender_local_predictor.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698