Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.dart

Issue 509563004: Give instances their own model class; move DartErrors out of instance-ref into their own error-ref. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.dart
diff --git a/runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.dart b/runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.dart
index cb738b5662d45e774c2355fe0db8e72279daa884..c71307f6a45c3df40fec07e85197ab3e800a3c1a 100644
--- a/runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.dart
+++ b/runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.dart
@@ -11,6 +11,7 @@ import 'service_ref.dart';
@CustomTag('inbound-reference')
class InboundReferenceElement extends ServiceRefElement {
+ @published ObservableMap ref;
Cutch 2014/08/28 14:46:05 ServiceMap
rmacnak 2014/08/28 19:41:05 We don't get a ServiceMap here for some reason.
InboundReferenceElement.created() : super.created();
dynamic get slot => ref['slot'];
@@ -32,7 +33,7 @@ class InboundReferenceElement extends ServiceRefElement {
dynamic expander() {
return expandEvent;
}
-
+
void expandEvent(bool expand, var done) {
assert(ref is ServiceMap);
if (expand) {
@@ -40,9 +41,7 @@ class InboundReferenceElement extends ServiceRefElement {
notifyPropertyChange(#ref, 0, 1);
}).whenComplete(done);
} else {
- ServiceMap refMap = ref;
- refMap['fields'] = null;
- refMap['elements'] = null;
+ inboundReferences = null;
done();
}
}

Powered by Google App Engine
This is Rietveld 408576698