Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2368)

Unified Diff: chrome/browser/autocomplete/autocomplete_controller.cc

Issue 509563002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/autocomplete/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/autocomplete/history_quick_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autocomplete/autocomplete_controller.cc
diff --git a/chrome/browser/autocomplete/autocomplete_controller.cc b/chrome/browser/autocomplete/autocomplete_controller.cc
index 0535cdbc6a1dff87c7cbcd9e9a76855ed30f00b8..a714a3ef8795edb5dc33c43022ac57c436c88a8d 100644
--- a/chrome/browser/autocomplete/autocomplete_controller.cc
+++ b/chrome/browser/autocomplete/autocomplete_controller.cc
@@ -265,7 +265,7 @@ void AutocompleteController::Start(const AutocompleteInput& input) {
// Call Start() on ZeroSuggestProvider with an INVALID AutocompleteInput
// to clear out zero-suggest |matches_|.
- if (*i == zero_suggest_provider_)
+ if (i->get() == zero_suggest_provider_)
(*i)->Start(AutocompleteInput(), minimal_changes);
else
(*i)->Start(input_, minimal_changes);
@@ -337,7 +337,7 @@ void AutocompleteController::StartZeroSuggest(const AutocompleteInput& input) {
// AutocompleteInput to clear out cached |matches_|, which ensures that
// they aren't used with zero suggest.
for (Providers::iterator i(providers_.begin()); i != providers_.end(); ++i) {
- if (*i == zero_suggest_provider_)
+ if (i->get() == zero_suggest_provider_)
(*i)->Start(input, false);
else
(*i)->Start(AutocompleteInput(), false);
« no previous file with comments | « no previous file | chrome/browser/autocomplete/history_quick_provider_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698