android_webview/browser/shared_renderer_state.h - Issue 509453002: android_webview : Class member variable WeakPtrFactory in proper order.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/shared_renderer_state.h

Issue 509453002: android_webview : Class member variable WeakPtrFactory in proper order. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/browser/net/android_stream_reader_url_request_job.h ('k') | android_webview/browser/shared_renderer_state.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/browser/shared_renderer_state.h

diff --git a/android_webview/browser/shared_renderer_state.h b/android_webview/browser/shared_renderer_state.h

index e4a5827590e263794bae2ea2e4515344e29827f8..b687503cb42cd61ed273c1c220fe41a27538cffa 100644

--- a/android_webview/browser/shared_renderer_state.h

+++ b/android_webview/browser/shared_renderer_state.h

@@ -79,7 +79,6 @@ class SharedRendererState {

scoped_refptr<base::MessageLoopProxy> ui_loop_;

BrowserViewRendererClient* client_on_ui_;

- base::WeakPtrFactory<SharedRendererState> weak_factory_on_ui_thread_;

base::WeakPtr<SharedRendererState> ui_thread_weak_ptr_;

base::CancelableClosure request_draw_gl_cancelable_closure_;

@@ -91,6 +90,8 @@ class SharedRendererState {

cc::ReturnedResourceArray returned_resources_;

base::Closure request_draw_gl_closure_;

+ base::WeakPtrFactory<SharedRendererState> weak_factory_on_ui_thread_;

DISALLOW_COPY_AND_ASSIGN(SharedRendererState);

};