Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 509413002: Revert of NaCl: Update revision in DEPS, r13666 -> r13668 (Closed)

Created:
6 years, 3 months ago by tim (not reviewing)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, native-client-reviews_googlegroups.com, noelallen_use_chromium, Yoshisato Yanagisawa, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of NaCl: Update revision in DEPS, r13666 -> r13668 (patchset #1 of https://codereview.chromium.org/513933003/) Reason for revert: attempting to fix compile failures. http://build.chromium.org/p/chromium.gpu/builders/GPU%20Win%20Builder/builds/11346/steps/compile/logs/stdio http://build.chromium.org/p/chromium.webkit/builders/Win%20Builder/builds/61269/steps/compile/logs/stdio Original issue's description: > NaCl: Update revision in DEPS, r13666 -> r13668 > > This pulls in the following Native Client changes: > > r13667: (yyanagisawa) Re-enable use of Goma on Windows, except when using the PNaCl toolchain > r13668: (noelallen) Force rebuild on cmd change. > > BUG=none > TEST=browser_tests and nacl_integration > CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build > TBR=bradnelson@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/ba2092ce9ac0792098dcca59f9a224e13825dcd5 TBR=bradnelson@chromium.org,mseaborn@chromium.org NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/71e48184cf293d4bdee271f753e9da7b2b202b29 Cr-Commit-Position: refs/heads/master@{#292411}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
tim (not reviewing)
Created Revert of NaCl: Update revision in DEPS, r13666 -> r13668
6 years, 3 months ago (2014-08-28 17:36:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tim@chromium.org/509413002/1
6 years, 3 months ago (2014-08-28 17:37:30 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as bd5eb4be0eefe6929c642ceee4fb5c95ab5535ae
6 years, 3 months ago (2014-08-28 17:38:25 UTC) #3
Mark Seaborn
@Tim: In future, can you please link to the failures before committing reverts? It's rather ...
6 years, 3 months ago (2014-08-29 00:10:21 UTC) #4
tim (not reviewing)
On 2014/08/29 00:10:21, Mark Seaborn wrote: > @Tim: In future, can you please link to ...
6 years, 3 months ago (2014-08-29 02:10:12 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:00:30 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71e48184cf293d4bdee271f753e9da7b2b202b29
Cr-Commit-Position: refs/heads/master@{#292411}

Powered by Google App Engine
This is Rietveld 408576698