Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: test/cctest/compiler/test-simplified-lowering.cc

Issue 509343002: Better typing and type verification (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Drop typedness from graph Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/compiler/test-simplified-lowering.cc
diff --git a/test/cctest/compiler/test-simplified-lowering.cc b/test/cctest/compiler/test-simplified-lowering.cc
index 73ac015f18d0c858830a03eb96ac09632f1d9ece..90f03da0afc85fa07c8a63ced1c3b9d7f4b9c441 100644
--- a/test/cctest/compiler/test-simplified-lowering.cc
+++ b/test/cctest/compiler/test-simplified-lowering.cc
@@ -35,8 +35,8 @@ class SimplifiedLoweringTester : public GraphBuilderTester<ReturnType> {
MachineType p3 = kMachNone,
MachineType p4 = kMachNone)
: GraphBuilderTester<ReturnType>(p0, p1, p2, p3, p4),
- typer(this->zone()),
- jsgraph(this->graph(), this->common(), &typer),
+ typer(this->graph(), MaybeHandle<Context>()),
+ jsgraph(this->graph(), this->common()),
lowering(&jsgraph) {}
Typer typer;
@@ -45,6 +45,7 @@ class SimplifiedLoweringTester : public GraphBuilderTester<ReturnType> {
void LowerAllNodes() {
this->End();
+ typer.Run();
lowering.LowerAllNodes();
}
@@ -614,8 +615,8 @@ class TestingGraph : public HandleAndZoneScope, public GraphAndBuilders {
explicit TestingGraph(Type* p0_type, Type* p1_type = Type::None())
: GraphAndBuilders(main_zone()),
- typer(main_zone()),
- jsgraph(graph(), common(), &typer) {
+ typer(graph(), MaybeHandle<Context>()),
+ jsgraph(graph(), common()) {
start = graph()->NewNode(common()->Start(2));
graph()->SetStart(start);
ret =
@@ -624,6 +625,7 @@ class TestingGraph : public HandleAndZoneScope, public GraphAndBuilders {
graph()->SetEnd(end);
p0 = graph()->NewNode(common()->Parameter(0), start);
p1 = graph()->NewNode(common()->Parameter(1), start);
+ typer.Run();
NodeProperties::SetBounds(p0, Bounds(p0_type));
NodeProperties::SetBounds(p1, Bounds(p1_type));
}
@@ -643,8 +645,7 @@ class TestingGraph : public HandleAndZoneScope, public GraphAndBuilders {
}
void Lower() {
- SimplifiedLowering lowering(&jsgraph);
- lowering.LowerAllNodes();
+ SimplifiedLowering(&jsgraph).LowerAllNodes();
}
// Inserts the node as the return value of the graph.

Powered by Google App Engine
This is Rietveld 408576698