Better typing and type verification

src/compiler/pipeline.h

Index: src/compiler/pipeline.h
diff --git a/src/compiler/pipeline.h b/src/compiler/pipeline.h
index f47c3c1284d3ae7cfaa6fa96795e2a165840afe3..0918f8268dfc463965ca023d0739e1d32020e49b 100644
--- a/src/compiler/pipeline.h
+++ b/src/compiler/pipeline.h
@@ -10,6 +10,7 @@
 #include "src/v8.h"
 
 #include "src/compiler.h"
+#include "src/compiler/verifier.h"

[Michael Starzinger, 2014/10/14 18:28:27]

Nope! Please don't inlclude any other header in this file from the compiler
directory. The reason is that pipeline.h is the only header allowed to be
included from outside the compiler directory and this leaks all definitions from
the verifier.h file to outside the compiler directory.

[rossberg, 2014/10/15 06:47:58]

Sigh. Proliferation like this is just one ugly consequence of not making the
graph sufficiently self-describing with respect to its being typed or not. You
asked for that.

I will try to make VerifyAndPrintGraph and its dependencies from private methods
into local static functions in pipeline.cc -- or forego best practice and use a
boolean argument. Whatever turns out less hacky.

[rossberg, 2014/10/15 08:59:08]

Done.

 
 // Note: TODO(turbofan) implies a performance improvement opportunity,
 //   and TODO(name) implies an incomplete implementation
@@ -58,7 +59,8 @@ class Pipeline {
                                     const SourcePositionTable* positions,
                                     const InstructionSequence* instructions);
   void PrintAllocator(const char* phase, const RegisterAllocator* allocator);
-  void VerifyAndPrintGraph(Graph* graph, const char* phase);
+  void VerifyAndPrintGraph(Graph* graph, const char* phase,
+                           Verifier::Typing = Verifier::TYPED);
   Handle<Code> GenerateCode(Linkage* linkage, Graph* graph, Schedule* schedule,
                             SourcePositionTable* source_positions);
 };