Better typing and type verification

src/compiler/generic-node-inl.h

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COMPILER_GENERIC_NODE_INL_H_
 #define V8_COMPILER_GENERIC_NODE_INL_H_
 
 #include "src/v8.h"
 
 #include "src/compiler/generic-graph.h"
 #include "src/compiler/generic-node.h"
 #include "src/zone.h"
 
 namespace v8 {
 namespace internal {
 namespace compiler {
 
 template <class B, class S>
 GenericNode<B, S>::GenericNode(GenericGraphBase* graph, int input_count)
     : BaseClass(graph->zone()),
       input_count_(input_count),
       has_appendable_inputs_(false),
       use_count_(0),
       first_use_(NULL),
       last_use_(NULL) {
-  inputs_.static_ = reinterpret_cast<Input*>(this + 1), AssignUniqueID(graph);
+  inputs_.static_ = reinterpret_cast<Input*>(this + 1);

[titzer, 2014/08/28 13:12:31]

That's a nice little gift

[Benedikt Meurer, 2014/08/29 07:00:58]

Ahem, can we please get rid of this undefined behaviour here? Even if we assume
that alignof is less than sizeof the concrete GenericNode (which we do not
ensure in any way), it is still not safe in general.

[rossberg, 2014/08/29 07:23:42]

I agree. Since this problem has nothing to do with this CL, feel free to fix it.
:)

+  AssignUniqueID(graph);
 }
 
 template <class B, class S>
 inline void GenericNode<B, S>::AssignUniqueID(GenericGraphBase* graph) {
   id_ = graph->NextNodeID();
 }
 
 template <class B, class S>
 inline typename GenericNode<B, S>::Inputs::iterator
 GenericNode<B, S>::Inputs::begin() {
@@ skipping 199 matching lines @@
     ++use;
     ++input;
   }
   return result;
 }
 }
 }
 }  // namespace v8::internal::compiler
 
 #endif  // V8_COMPILER_GENERIC_NODE_INL_H_