Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 509323004: ozone: Whitelist some libs for the embedded build (Closed)

Created:
6 years, 3 months ago by spang
Modified:
6 years, 3 months ago
Reviewers:
dnicoara, bashi
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ozone: Whitelist some libs for the embedded build Also switch harfbuzz to internal by default to minimize deps. BUG=178543 TEST=run the tool TBR=bashi1 Committed: https://crrev.com/94b4625f9c72a61459a27dda17b8e75ad6967311 Cr-Commit-Position: refs/heads/master@{#292521}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M third_party/harfbuzz-ng/harfbuzz.gyp View 1 chunk +1 line, -1 line 0 comments Download
M tools/check_ecs_deps/check_ecs_deps.py View 3 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
spang
spang@chromium.org changed reviewers: + bashi@chromium.org, dnicoara@chromium.org
6 years, 3 months ago (2014-08-28 20:14:22 UTC) #1
spang
6 years, 3 months ago (2014-08-28 20:14:22 UTC) #2
dnicoara
lgtm
6 years, 3 months ago (2014-08-28 20:21:49 UTC) #3
spang
The CQ bit was checked by spang@chromium.org
6 years, 3 months ago (2014-08-28 21:58:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/509323004/1
6 years, 3 months ago (2014-08-28 21:59:32 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-28 23:32:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 3c7679024cee0117e92cab60c920d2a518d570e1
6 years, 3 months ago (2014-08-29 00:33:01 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:04:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/94b4625f9c72a61459a27dda17b8e75ad6967311
Cr-Commit-Position: refs/heads/master@{#292521}

Powered by Google App Engine
This is Rietveld 408576698