Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: content/child/service_worker/service_worker_dispatcher.cc

Issue 509283003: ServiceWorker: Change the return value of ServiceWorkerRegistration::unregister to boolean (4/4) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporate the reveiews Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/service_worker/service_worker_dispatcher.cc
diff --git a/content/child/service_worker/service_worker_dispatcher.cc b/content/child/service_worker/service_worker_dispatcher.cc
index bfe4075621b3e16e887ca81b777e92c1d962ed60..21a45bdf1f41ec466bf9c50e96ce7c57fee86249 100644
--- a/content/child/service_worker/service_worker_dispatcher.cc
+++ b/content/child/service_worker/service_worker_dispatcher.cc
@@ -257,12 +257,8 @@ void ServiceWorkerDispatcher::OnUnregistered(
DCHECK(callbacks);
if (!callbacks)
return;
-#ifdef DISABLE_SERVICEWORKER_UNREGISTER_RESOLVE_TO_BOOLEAN
- callbacks->onSuccess(NULL);
-#else
bool is_success = true;
callbacks->onSuccess(&is_success);
-#endif
pending_unregistration_callbacks_.Remove(request_id);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698