Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1210)

Issue 509283003: ServiceWorker: Change the return value of ServiceWorkerRegistration::unregister to boolean (4/4) (Closed)

Created:
6 years, 3 months ago by shimazu
Modified:
6 years, 3 months ago
Reviewers:
nhiroki, horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Change the return value of ServiceWorkerRegistration::unregister to boolean (4/4) BUG=390894 TEST=N/A Committed: https://crrev.com/620f4c6da423d48ec6eab392e08408dbdd18008d Cr-Commit-Position: refs/heads/master@{#293154}

Patch Set 1 #

Patch Set 2 : Incorporate the reveiews #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M content/child/service_worker/service_worker_dispatcher.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
shimazu
shimazu@chromium.org changed reviewers: + horo@chromium.org, nhiroki@chromium.org
6 years, 3 months ago (2014-08-28 09:49:18 UTC) #1
shimazu
horo@chromium.org: Please review changes in nhiroki@chromium.org: Please review changes in
6 years, 3 months ago (2014-08-28 09:49:18 UTC) #2
shimazu
6 years, 3 months ago (2014-08-29 07:08:33 UTC) #3
horo
lgtm
6 years, 3 months ago (2014-08-29 07:37:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shimazu@chromium.org/509283003/20001
6 years, 3 months ago (2014-09-03 14:18:42 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 3 months ago (2014-09-03 16:15:28 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as b109e380b8e62cc8c165c959e95b53c0a98042f8
6 years, 3 months ago (2014-09-03 16:52:46 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:26:17 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/620f4c6da423d48ec6eab392e08408dbdd18008d
Cr-Commit-Position: refs/heads/master@{#293154}

Powered by Google App Engine
This is Rietveld 408576698