Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 509213005: Indexed DB: Regression test to ensure Blobs preserve content-type (Closed)

Created:
6 years, 3 months ago by jsbell
Modified:
6 years, 3 months ago
Reviewers:
cmumford
CC:
blink-reviews, jsbell+idb_chromium.org, dgrogan, cmumford
Project:
blink
Visibility:
Public.

Description

Indexed DB: Regression test to ensure Blobs preserve content-type The Blob type was serialized/restored correctly on the Blink side, but not on the Chromium side, so when reading a Blob as a stream the type would be unset. The Chromium-side fix is: https://codereview.chromium.org/511373002 BUG=408120 R=cmumford@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181074

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -0 lines) Patch
A LayoutTests/storage/indexeddb/blob-contenttype.html View 1 chunk +59 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
jsbell
cmumford@ - please take a look?
6 years, 3 months ago (2014-08-28 19:19:28 UTC) #1
cmumford
lgtm
6 years, 3 months ago (2014-08-28 20:37:47 UTC) #2
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 3 months ago (2014-08-28 22:53:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/509213005/1
6 years, 3 months ago (2014-08-28 22:53:34 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 3 months ago (2014-08-29 00:02:57 UTC) #5
jsbell
The failures may be due to trying against lkgr...
6 years, 3 months ago (2014-08-29 00:55:22 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-29 01:05:58 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/23110)
6 years, 3 months ago (2014-08-29 01:05:59 UTC) #8
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 3 months ago (2014-08-29 03:14:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/509213005/1
6 years, 3 months ago (2014-08-29 03:14:54 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-08-29 04:22:13 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181074

Powered by Google App Engine
This is Rietveld 408576698