Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(994)

Unified Diff: tools/metrics/rappor/rappor.xml

Issue 509203002: Create a mechanism for reporting rappor metrics from non-UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rename, add params to rappor.xml Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/rappor/rappor_service.cc ('K') | « components/rappor/rappor_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/rappor/rappor.xml
diff --git a/tools/metrics/rappor/rappor.xml b/tools/metrics/rappor/rappor.xml
index 743f98a214a0c51248d6b518bc15732f30e20ad3..a647129db7a1cde9044451561928705e7476b726 100644
--- a/tools/metrics/rappor/rappor.xml
+++ b/tools/metrics/rappor/rappor.xml
@@ -15,6 +15,47 @@ TODO(holte): Add validation and pretty printing scripts.
<rappor-configuration>
+<!--
+Parameters that rappor metrics can be collected with. This list should be
+kept in sync with parameter type definitions in
+components/rappor/rappor_service.cc.
Alexei Svitkine (slow) 2014/11/03 21:48:21 Can you also file a bug that we should make a pres
Steven Holte 2014/11/04 02:44:20 Done. https://code.google.com/p/chromium/issues/de
+-->
+
+<rappor-parameter-types>
+
+<rappor-parameters name="ETLD_PLUS_ONE">
+ <summary>
+ Parameters suitable for collecting the domain and registry of a URL from
+ UMA opt-in users.
+ </summary>
+ <parameters num-cohorts="128"
+ bytes="16"
+ hash-functions="2"
+ fake-prob=".5"
+ fake-one-prob=".5"
+ one-coin-prob=".75"
+ zero-coin-prob=".25"
+ always-enabled="false">
+ </parameters>
+</rappor-parameters>
+
+<rappor-parameters name="FULL_POPULATION">
+ <summary>
+ Parameters suitable for metrics collected from the full population of
+ chrome users.
Alexei Svitkine (slow) 2014/11/03 21:48:21 Nit: capitalize Chrome
Steven Holte 2014/11/04 02:44:20 Changed this description.
+ </summary>
+ <parameters num-cohorts="128"
+ bytes="1"
+ hash-functions="2"
+ fake-prob=".5"
+ fake-one-prob=".5"
+ one-coin-prob=".75"
+ zero-coin-prob=".25"
+ always-enabled="true">
+</rappor-parameters>
+
+</rappor-parameter-types>
+
<!-- Rappor metric definitions -->
<rappor-metrics>
« components/rappor/rappor_service.cc ('K') | « components/rappor/rappor_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698