Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 509193002: Allow requesting a copy of a surface. (Closed)

Created:
6 years, 3 months ago by jbauman
Modified:
6 years, 3 months ago
Reviewers:
jamesr
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Allow requesting a copy of a surface. Instead of requesting a layer, a copy of the entire surface is requested. Actually handling the request isn't implemented yet. BUG=397730 Committed: https://crrev.com/115bf013f41605a7244e3fa0d505581bdc1aee2d Cr-Commit-Position: refs/heads/master@{#292498}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2 lines) Patch
M cc/surfaces/surface.h View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/surfaces/surface.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M cc/surfaces/surface_factory.h View 2 chunks +3 lines, -0 lines 0 comments Download
M cc/surfaces/surface_factory.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M content/browser/compositor/delegated_frame_host.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jbauman
jbauman@chromium.org changed reviewers: + jamesr@chromium.org
6 years, 3 months ago (2014-08-28 19:06:37 UTC) #1
jbauman
6 years, 3 months ago (2014-08-28 19:06:37 UTC) #2
jamesr
lgtm
6 years, 3 months ago (2014-08-28 21:36:19 UTC) #3
jamesr
Guessing semantics are it gets a copy of whichever frame is the most recent eligible ...
6 years, 3 months ago (2014-08-28 21:36:39 UTC) #4
jbauman
On 2014/08/28 21:36:39, jamesr wrote: > Guessing semantics are it gets a copy of whichever ...
6 years, 3 months ago (2014-08-28 21:44:15 UTC) #5
jbauman
The CQ bit was checked by jbauman@chromium.org
6 years, 3 months ago (2014-08-28 22:01:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/509193002/1
6 years, 3 months ago (2014-08-28 22:03:12 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as ace25bcedc2ed5cb8d3ebe954c81d04abf05adbc
6 years, 3 months ago (2014-08-28 23:34:24 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:03:34 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/115bf013f41605a7244e3fa0d505581bdc1aee2d
Cr-Commit-Position: refs/heads/master@{#292498}

Powered by Google App Engine
This is Rietveld 408576698