Issue 509183002: Revert of always scale to an integer; compensate for fractional image sizes by leaving the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 509183002: Revert of always scale to an integer; compensate for fractional image sizes by leaving the (Closed)

Created:
6 years, 3 months ago by humper

Modified:
6 years, 3 months ago

Reviewers:
djsollen, reed1

CC:
reviews_skia.org, jbroman

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of always scale to an integer; compensate for fractional image sizes by leaving the fractional scale i… (patchset #6 of https://codereview.chromium.org/470233002/) Reason for revert: Patch seems to have broken image scaling replay tests on one android platform and chromeos. http://108.170.220.21:10117/builders/Test-Android-Xoom-Tegra2-Arm7-Release/builds/2901/steps/RunDM/logs/stdio Original issue's description: > always scale to an integer; compensate for fractional image sizes by leaving the fractional scale in the matrix > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/ce7b1d5fadda5e0fd5a40257d4c8e1b6a0279597 TBR=reed@google.com NOTREECHECKS=true NOTRY=true BUG=skia:

Created: 6 years, 3 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -60 lines)			Patch
M	expectations/gm/ignored-tests.txt	View	1 chunk	+1 line, -22 lines	0 comments	Download
M	gyp/skia_for_chromium_defines.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/core/SkBitmapProcState.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/core/SkBitmapProcState.cpp	View	5 chunks	+13 lines, -33 lines	0 comments	Download
M	tests/ScaledImageCache.cpp	View	1 chunk	+1 line, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

humper

Created Revert of always scale to an integer; compensate for fractional image sizes by leaving ...

6 years, 3 months ago (2014-08-27 23:57:59 UTC) #1

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 3 months ago (2014-08-27 23:58:10 UTC) #2

commit-bot: I haz the power

6 years, 3 months ago (2014-08-28 12:58:09 UTC) #4

The CQ bit was unchecked by commit-bot@chromium.org