Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 509173005: Supervised user interstitial: Remove image URL resolving hack. (Closed)

Created:
6 years, 3 months ago by Marc Treib
Modified:
6 years, 3 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, pam+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Supervised user interstitial: Remove image URL resolving hack. The URL now contains a protocol (b/17204752) so we don't need this anymore. BUG=404671 Committed: https://crrev.com/885fee17a8df62e0ab51c06742d55f459bae6ea8 Cr-Commit-Position: refs/heads/master@{#292590}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -18 lines) Patch
M chrome/browser/supervised_user/supervised_user_interstitial.cc View 2 chunks +2 lines, -18 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Marc Treib
treib@chromium.org changed reviewers: + bauerb@chromium.org
6 years, 3 months ago (2014-08-28 14:11:44 UTC) #1
Marc Treib
PTAL!
6 years, 3 months ago (2014-08-28 14:11:44 UTC) #2
Bernhard Bauer
lgtm
6 years, 3 months ago (2014-08-28 15:08:39 UTC) #3
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 3 months ago (2014-08-28 15:09:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/509173005/1
6 years, 3 months ago (2014-08-28 15:09:42 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-28 16:02:35 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 16:30:14 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_triggered_tests/builds/40616)
6 years, 3 months ago (2014-08-28 16:30:15 UTC) #8
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 3 months ago (2014-08-29 07:45:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/509173005/1
6 years, 3 months ago (2014-08-29 07:45:18 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as f66cd0031d9df64dfd896080af1f81a5276597fe
6 years, 3 months ago (2014-08-29 08:08:08 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:06:58 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/885fee17a8df62e0ab51c06742d55f459bae6ea8
Cr-Commit-Position: refs/heads/master@{#292590}

Powered by Google App Engine
This is Rietveld 408576698