Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 509163002: Make git-nav-downstream synchronous (Closed)

Created:
6 years, 3 months ago by asanka
Modified:
6 years, 3 months ago
Reviewers:
agable, iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Project:
tools
Visibility:
Public.

Description

Make git-nav-downstream synchronous Currently git-nav-downstream invokes 'git checkout' in a subprocess, but exits without waiting for the checkout to complete. Instead wait for the subprocess to complete. BUG=376101 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291701

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M git_nav_downstream.py View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
asanka
asanka@chromium.org changed reviewers: + agable@chromium.org
6 years, 3 months ago (2014-08-27 20:38:48 UTC) #1
asanka
6 years, 3 months ago (2014-08-27 20:38:52 UTC) #2
iannucci
iannucci@chromium.org changed reviewers: + iannucci@chromium.org
6 years, 3 months ago (2014-08-27 21:41:51 UTC) #3
iannucci
Oh, good catch. LGTM
6 years, 3 months ago (2014-08-27 21:41:51 UTC) #4
asanka
On 2014/08/27 21:41:51, iannucci wrote: > Oh, good catch. LGTM Thanks!
6 years, 3 months ago (2014-08-27 21:47:55 UTC) #5
asanka
The CQ bit was checked by asanka@chromium.org
6 years, 3 months ago (2014-08-28 00:23:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/509163002/1
6 years, 3 months ago (2014-08-28 00:23:34 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-08-28 00:25:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 291701

Powered by Google App Engine
This is Rietveld 408576698