New bigint implementation in the vm.

runtime/vm/snapshot_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 
 #include "include/dart_debugger_api.h"
 #include "platform/assert.h"
-#include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/dart_api_impl.h"
 #include "vm/dart_api_message.h"
 #include "vm/dart_api_state.h"
 #include "vm/flags.h"
 #include "vm/snapshot.h"
 #include "vm/symbols.h"
 #include "vm/unicode.h"
 #include "vm/unit_test.h"
 
@@ skipping 60 matching lines @@
       break;
     case Dart_CObject_kBool:
       EXPECT_EQ(first->value.as_bool, second->value.as_bool);
       break;
     case Dart_CObject_kInt32:
       EXPECT_EQ(first->value.as_int32, second->value.as_int32);
       break;
     case Dart_CObject_kInt64:
       EXPECT_EQ(first->value.as_int64, second->value.as_int64);
       break;
-    case Dart_CObject_kBigint:
-      EXPECT_STREQ(first->value.as_bigint, second->value.as_bigint);
+    case Dart_CObject_kBigint: {
+      char* first_hex_value = TestCase::BigintToHexValue(first);
+      char* second_hex_value = TestCase::BigintToHexValue(second);
+      EXPECT_STREQ(first_hex_value, second_hex_value);
+      free(first_hex_value);
+      free(second_hex_value);
       break;
+    }
     case Dart_CObject_kDouble:
       EXPECT_EQ(first->value.as_double, second->value.as_double);
       break;
     case Dart_CObject_kString:
       EXPECT_STREQ(first->value.as_string, second->value.as_string);
       break;
     case Dart_CObject_kTypedData:
       EXPECT_EQ(first->value.as_typed_data.length,
                 second->value.as_typed_data.length);
       for (int i = 0; i < first->value.as_typed_data.length; i++) {
@@ skipping 287 matching lines @@
   bigint ^= Integer::NewCanonical(str);
   writer.WriteMessage(bigint);
   intptr_t buffer_len = writer.BytesWritten();
 
   // Read object back from the snapshot.
   SnapshotReader reader(buffer, buffer_len,
                         Snapshot::kMessage, Isolate::Current());
   Bigint& obj = Bigint::Handle();
   obj ^= reader.ReadObject();
 
-  EXPECT_STREQ(BigintOperations::ToHexCString(bigint, &allocator),
-               BigintOperations::ToHexCString(obj, &allocator));
+  EXPECT_STREQ(bigint.ToHexCString(allocator), obj.ToHexCString(allocator));
 
   // Read object back from the snapshot into a C structure.
   ApiNativeScope scope;
   ApiMessageReader api_reader(buffer, buffer_len, &zone_allocator);
   Dart_CObject* root = api_reader.ReadMessage();
-  // Bigint not supported.
   EXPECT_NOTNULL(root);
   EXPECT_EQ(Dart_CObject_kBigint, root->type);
-  EXPECT_STREQ("270FFFFFFFFFFFFFD8F0", root->value.as_bigint);
+  char* hex_value = TestCase::BigintToHexValue(root);
+  EXPECT_STREQ(cstr, hex_value);
+  free(hex_value);
   CheckEncodeDecodeMessage(root);
 }
 
 
 Dart_CObject* SerializeAndDeserializeBigint(const Bigint& bigint) {
   // Write snapshot with object content.
   uint8_t* buffer;
   MessageWriter writer(&buffer, &zone_allocator);
   writer.WriteMessage(bigint);
   intptr_t buffer_len = writer.BytesWritten();
 
   // Read object back from the snapshot.
   SnapshotReader reader(buffer, buffer_len,
                         Snapshot::kMessage, Isolate::Current());
   Bigint& serialized_bigint = Bigint::Handle();
   serialized_bigint ^= reader.ReadObject();
-  const char* str1 = BigintOperations::ToHexCString(bigint, allocator);
-  const char* str2 =
-      BigintOperations::ToHexCString(serialized_bigint, allocator);
+  const char* str1 = bigint.ToHexCString(allocator);
+  const char* str2 = serialized_bigint.ToHexCString(allocator);
   EXPECT_STREQ(str1, str2);
   free(const_cast<char*>(str1));
   free(const_cast<char*>(str2));
 
   // Read object back from the snapshot into a C structure.
   ApiMessageReader api_reader(buffer, buffer_len, &zone_allocator);
   Dart_CObject* root = api_reader.ReadMessage();
   // Bigint not supported.
   EXPECT_NOTNULL(root);
   CheckEncodeDecodeMessage(root);
   return root;
 }
 
 
 void CheckBigint(const char* bigint_value) {
   StackZone zone(Isolate::Current());
   ApiNativeScope scope;
 
   Bigint& bigint = Bigint::Handle();
-  bigint ^= BigintOperations::NewFromCString(bigint_value);
+  bigint ^= Bigint::NewFromCString(bigint_value);
   Dart_CObject* bigint_cobject = SerializeAndDeserializeBigint(bigint);
   EXPECT_EQ(Dart_CObject_kBigint, bigint_cobject->type);
-  if (bigint_value[0] == '0') {
-    EXPECT_STREQ(bigint_value + 2, bigint_cobject->value.as_bigint);
-  } else {
-    EXPECT_EQ('-', bigint_value[0]);
-    EXPECT_EQ('-', bigint_cobject->value.as_bigint[0]);
-    EXPECT_STREQ(bigint_value + 3, bigint_cobject->value.as_bigint + 1);
-  }
+  char* hex_value = TestCase::BigintToHexValue(bigint_cobject);
+  EXPECT_STREQ(bigint_value, hex_value);
+  free(hex_value);
 }
 
 
 TEST_CASE(SerializeBigint2) {
   CheckBigint("0x0");
   CheckBigint("0x1");
   CheckBigint("-0x1");
   CheckBigint("0x11111111111111111111");
   CheckBigint("-0x11111111111111111111");
   CheckBigint("0x9876543210987654321098765432109876543210");
@@ skipping 1162 matching lines @@
       bigint ^= Api::UnwrapHandle(bigint_result);
       writer.WriteMessage(bigint);
       intptr_t buffer_len = writer.BytesWritten();
 
       // Read object back from the snapshot into a C structure.
       ApiNativeScope scope;
       ApiMessageReader api_reader(buffer, buffer_len, &zone_allocator);
       Dart_CObject* root = api_reader.ReadMessage();
       EXPECT_NOTNULL(root);
       EXPECT_EQ(Dart_CObject_kBigint, root->type);
-      EXPECT_STREQ("-424242424242424242424242424242424242",
-                   root->value.as_bigint);
+      char* hex_value = TestCase::BigintToHexValue(root);
+      EXPECT_STREQ("-0x424242424242424242424242424242424242", hex_value);
+      free(hex_value);
       CheckEncodeDecodeMessage(root);
     }
     CheckString(ascii_string_result, "Hello, world!");
     CheckString(non_ascii_string_result, "Blåbærgrød");
     CheckString(non_bmp_string_result,
                 "\xf0\x90\x80\x80"
                 "\xf0\x9f\x98\x81"
                 "\xf0\x9f\x98\xb7"
                 "\xf0\xa0\x80\x80");
     CheckStringInvalid(lead_surrogate_string_result);
@@ skipping 425 matching lines @@
       // Generate a list of bigints from Dart code.
       ApiNativeScope scope;
       Dart_CObject* root = GetDeserializedDartMessage(lib, "getBigintList");
       EXPECT_NOTNULL(root);
       EXPECT_EQ(Dart_CObject_kArray, root->type);
       EXPECT_EQ(kArrayLength, root->value.as_array.length);
       for (int i = 0; i < kArrayLength; i++) {
         Dart_CObject* element = root->value.as_array.values[i];
         EXPECT_EQ(root->value.as_array.values[0], element);
         EXPECT_EQ(Dart_CObject_kBigint, element->type);
-        EXPECT_STREQ("1234567890123456789012345678901234567890",
-                     element->value.as_bigint);
+        char* hex_value = TestCase::BigintToHexValue(element);
+        EXPECT_STREQ("0x1234567890123456789012345678901234567890", hex_value);
+        free(hex_value);
       }
     }
     {
       // Generate a list of doubles from Dart code.
       ApiNativeScope scope;
       Dart_CObject* root = GetDeserializedDartMessage(lib, "getDoubleList");
       EXPECT_NOTNULL(root);
       EXPECT_EQ(Dart_CObject_kArray, root->type);
       EXPECT_EQ(kArrayLength, root->value.as_array.length);
       Dart_CObject* element = root->value.as_array.values[0];
@@ skipping 193 matching lines @@
       // Generate a list of bigints from Dart code.
       ApiNativeScope scope;
       Dart_CObject* root = GetDeserializedDartMessage(lib, "getBigintList");
       EXPECT_NOTNULL(root);
       EXPECT_EQ(Dart_CObject_kArray, root->type);
       EXPECT_EQ(kArrayLength, root->value.as_array.length);
       for (int i = 0; i < kArrayLength; i++) {
         Dart_CObject* element = root->value.as_array.values[i];
         EXPECT_EQ(root->value.as_array.values[0], element);
         EXPECT_EQ(Dart_CObject_kBigint, element->type);
-        EXPECT_STREQ("1234567890123456789012345678901234567890",
-                     element->value.as_bigint);
+        char* hex_value = TestCase::BigintToHexValue(element);
+        EXPECT_STREQ("0x1234567890123456789012345678901234567890", hex_value);
+        free(hex_value);
       }
     }
     {
       // Generate a list of doubles from Dart code.
       ApiNativeScope scope;
       Dart_CObject* root = GetDeserializedDartMessage(lib, "getDoubleList");
       EXPECT_NOTNULL(root);
       EXPECT_EQ(Dart_CObject_kArray, root->type);
       EXPECT_EQ(kArrayLength, root->value.as_array.length);
       Dart_CObject* element = root->value.as_array.values[0];
@@ skipping 409 matching lines @@
   StackZone zone(Isolate::Current());
   uint8_t* buffer;
   MessageWriter writer(&buffer, &zone_allocator);
   writer.WriteInlinedObjectHeader(kOmittedObjectId);
   // For performance, we'd like single-byte headers when ids are omitted.
   // If this starts failing, consider renumbering the snapshot ids.
   EXPECT_EQ(1, writer.BytesWritten());
 }
 
 }  // namespace dart